openwhisk-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bertrand Delacretaz <bdelacre...@apache.org>
Subject Re: [VOTE] release Apache OpenWhisk Package Alarm, Package Cloudant, and Package Kafka 2.0.0 (incubating)
Date Mon, 01 Apr 2019 13:02:53 GMT
Hi,

+1 for the releases of the 3 packages listed below.

Checked signatures, digests and build with "gradle distDocker".

As things to fix for next time, which do not block this release IMO, I
see several source files using a short-form Apache license header:

  // Licensed to the Apache Software Foundation (ASF) under one or
more contributor
 // license agreements; and to You under the Apache License, Version 2.0.

Was that discussed and found ok? Sorry if I forgot that discussion, a
link to it is a fine answer. I see Justin made a similar comment.

https://www.apache.org/legal/src-headers.html does mention such a
short form header but for "minified JavaScript" which is not the case
here.

And some minor comments:

-README should include or point to build instructions, I don't think
any of them do. Ok, those instructions are mostly trivial but that
that can just be a quick note or link to the appropriate build file to
avoid duplicating information. I assume it's just "gradle distDocker"
but it's good to know what's the recommended build command when
someone starts looking at these modules.

-The READMEs should also say "Apache OpenWhisk" more visibly than just
in the incubation disclaimer. Ideally in the README's title.

Packages:

SHA512(openwhisk-package-alarms-2.0.0-incubating-sources.tar.gz)=
d7e2925016674869c502fcf7ffdc087b80b84c5d4a555a1d0409d92eefb2f82fe36f821612c6a905f899c6d6ccba201086d5e58a6ed50d6e4571e0966ab3f9b0

SHA512(openwhisk-package-cloudant-2.0.0-incubating-sources.tar.gz)=
3f1e599c595a83fcf11a49ed5d7166d44efaba042f6e1588fa9b2054bbf3363ee02e1507a93c3f6b204c65ab2f7c94fd4393e4470ffc113dfef243d3739ab4d4

SHA512(openwhisk-package-kafka-2.0.0-incubating-sources.tar.gz)=
d1dc18a0dd7b4a648baffa1d1dde0647f6c9c0b032546dd11dc2728a5ff91a224695b01ecdeb3e5c5b9f4601817506479d67412ce875e4a1df21ee39d216d433

-Bertrand

Mime
View raw message