openwhisk-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bertrand Delacretaz <>
Subject Re: [VOTE] release Apache OpenWhisk Package Alarm, Package Cloudant, and Package Kafka 2.0.0 (incubating)
Date Mon, 01 Apr 2019 13:02:53 GMT

+1 for the releases of the 3 packages listed below.

Checked signatures, digests and build with "gradle distDocker".

As things to fix for next time, which do not block this release IMO, I
see several source files using a short-form Apache license header:

  // Licensed to the Apache Software Foundation (ASF) under one or
more contributor
 // license agreements; and to You under the Apache License, Version 2.0.

Was that discussed and found ok? Sorry if I forgot that discussion, a
link to it is a fine answer. I see Justin made a similar comment. does mention such a
short form header but for "minified JavaScript" which is not the case

And some minor comments:

-README should include or point to build instructions, I don't think
any of them do. Ok, those instructions are mostly trivial but that
that can just be a quick note or link to the appropriate build file to
avoid duplicating information. I assume it's just "gradle distDocker"
but it's good to know what's the recommended build command when
someone starts looking at these modules.

-The READMEs should also say "Apache OpenWhisk" more visibly than just
in the incubation disclaimer. Ideally in the README's title.






View raw message