From dev-return-3386-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Tue Mar 19 18:19:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 59100180626 for ; Tue, 19 Mar 2019 19:19:11 +0100 (CET) Received: (qmail 56247 invoked by uid 500); 19 Mar 2019 18:19:10 -0000 Mailing-List: contact dev-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list dev@openwhisk.apache.org Received: (qmail 55643 invoked by uid 99); 19 Mar 2019 18:19:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2019 18:19:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D7232C28BC for ; Tue, 19 Mar 2019 18:19:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.202 X-Spam-Level: X-Spam-Status: No, score=-0.202 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WG3xv_N7syXt for ; Tue, 19 Mar 2019 18:19:06 +0000 (UTC) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A3D445F11F for ; Tue, 19 Mar 2019 18:09:49 +0000 (UTC) Received: by mail-it1-f175.google.com with SMTP id m137so11881203ita.0 for ; Tue, 19 Mar 2019 11:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=frfpPXUc5RSe3L8rCriFjK2RGlBtFqLlOVLVxLg8QRc=; b=LLstkfG77KniyQIgxmTkirllq1wzgZLdbV+4PdmAIefH2+Nki/J8F/N7wDE0i2kxE4 8Bq577AemT79uUOGCa0/qa+0OmN0qCU+AGpW4A41ruiXehszHYL8+khb5NgEEbFm8geH 06NWc99KiPmwGq+ZiUQzBQ5ZNh+AHpe7F1szGwjSITS98+5qXUqmCofORJMCTnnLCJPR ANb7SIXewDZNf5OPZP1TZ9KVcuwskvIupNl5zGclJv0YZtoqcQCWTpjNCboR0dK/BvSK mlGus0KajygvKNhNn9OifdU5a25gljA8DGlYpCOcQhqVdWMteV/FGsH1G+NEkrqLkOSq AMBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=frfpPXUc5RSe3L8rCriFjK2RGlBtFqLlOVLVxLg8QRc=; b=O18+gUu/kQibJF78f6qz3exaRuYHnSb+mGAOt2485exCDVlCAb+TeVJl9rNUzu/2iI gDMCBS2R8MdyE96K6IaxCmE4/ug9uJnvA2ZWZ4IuiAcznOaCoktOiUXbZ7Gh4Jpnum02 oEgbJ1E7NtG309DSVzNUkm/wdIvJkO7WyeUdJdb1bMeREK0D8FjFKprTpW0r/qCt5NKc ruW8Yi6CbjkKhaAKyq42ccHTLGQiAAbHe8Paz8cUVpwC32YTIazlZ7deUOu/qp13B7hf AwBKf+y0DW6egXmNAROwxSh5oX6NdP/+QysOGIBo/Kpz/JvXZPNWUviRJkmwFF9f4P5g TAig== X-Gm-Message-State: APjAAAX2qF1fAycJNcZCkimvrz4dVqusftPp5VM0w7hzVndXrYTpcPNl CdQKBugT0Y0HvHxTdphdWAHjgaNakwq1BR7jMlfkMA== X-Google-Smtp-Source: APXvYqxGf3+cl6BmO/oKLsn4eZ5PC3OlE4gYiIrq4xx6XTiJuEHvEWwzdzuJ5XnjscZqfcAgsvayKY5YUKPcNeum/Hk= X-Received: by 2002:a24:4c82:: with SMTP id a124mr2280460itb.163.1553018988114; Tue, 19 Mar 2019 11:09:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Matt Sicker Date: Tue, 19 Mar 2019 13:09:36 -0500 Message-ID: Subject: Re: [VOTE] release Apache OpenWhisk CLI 0.10.0-incubating To: dev@openwhisk.apache.org Content-Type: text/plain; charset="UTF-8" +1 [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] DISCLAIMER is included. [x] Source code artifacts have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each OpenWhisk repository. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. Some notes from testing releases: * Disclaimer file would be nice to have reflowed as a normal text file with ~80 character width limits, or at least written like a typical text source file where each sentence is on its own line. Sort of a personal preference, though when you compare the disclaimer with the other usual files (LICENSE and NOTICE), it's not consistent. * client-go doesn't seem to have any tests? I ran `make test` and got an error of no tests being available, though `make integration_test` passed ok. * Tested with Gradle 5.2.1 and Go 1.12.1. See next point for why. * I know this debate has been had ad nauseum, but including gradle wrapper scripts without the bootstrap binary (which isn't allowed, I know) makes it kind of pointless to include. This is more of an issue for people like myself who don't use Gradle that often but rely on scripts like gdub to help manage Gradle usage. I've seen some efforts on the Maven wrapper side of things to try and make a self-booting Java source file or similar to download the wrapper binary at runtime, and such a thing might be doable as a Groovy script or a Java "script" (Java 11 style). This is a usability concern to me because typical users who install Gradle on their machine will only have the latest version of Gradle available, so if your build isn't compatible with, say, 4.10.x or 5.2.x (e.g., some people still use Gradle 2.x, and 4.x is the first release of Gradle that removed deprecated APIs from 2.x), then I have the fun job of figuring out which version of Gradle I need. :( - For comparison, I didn't need to install some specific version of Make or Maven to test anything else. - I also just filed a ticket with gdub to help support this use case. We'll see if this becomes a non-problem. :) * I haven't really combed through literally every file to ensure license headers and notice are correct, though I'm assuming this has been kept up to date so far. If that's not the case, then I'll have to dig through these releases in more depth next time. -- Matt Sicker