openwhisk-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michele Sciabarra <mich...@sciabarra.com>
Subject Re: Is it me or there is a bug in the mandatory tests?
Date Tue, 11 Sep 2018 19:40:06 GMT
Sorry but I do not get it. Are not the values in the map of the test supposed to be  passed
to the runtime as enviroment variables?

The test checks the values of the environment variables read by the code are the same in the
map.
the "take(1)" is passing only ONE enviroment variables. 

And I keep getting 

runtime.actionContainers.ActionLoopBasicGoTests > runtime proxy should confirm expected
environment variables FAILED
    org.scalatest.exceptions.TestFailedException: api_key "" was not equal to "abc"

If I remove the "take(1)" the test works.

If the variables are not passed by the withContainer(env.toMap) in which other way are the
enviroment variables are sent to the runtime?


-- 
  Michele Sciabarra
  michele@sciabarra.com

----- Original message -----
From: Rodric Rabbah <rodric@gmail.com>
To: dev@openwhisk.apache.org
Subject: Re: Is it me or there is a bug in the mandatory tests?
Date: Tue, 11 Sep 2018 19:29:32 +0000

it's not a bug in that the API host is provided as an environment variable
at container startup.
so the data passed into the container at /run does not include the
environment variable (today).

-r

On Tue, Sep 11, 2018 at 7:09 PM Michele Sciabarra <michele@sciabarra.com>
wrote:

> This is a separate issue related to the test 'it should  confirm expected
> environment variables'
>
> I was trying hard to pass this test and failing, and finally investigated
> the test code.
>
> I see this line:
>
>
> https://github.com/apache/incubator-openwhisk/blob/cfd50eee4194142e95bad6dfd8bf96ff08187050/tests/src/test/scala/actionContainers/BasicActionRunnerTests.scala#L276
>
> val (out, err) = withActionContainer(env.take(1).toMap)
>
> is it me, or that "take(1)" will limit the env to only one environment
> variable?
> Indeed, removing that take(1) I pass the test.
>
> Please let me know because that bug is preventing me to submit the PR and
> release a heavily tested and robust "golang" runtime
>
>
> --
>   Michele Sciabarra
>   michele@sciabarra.com
>

Mime
View raw message