Mailing-List: contact dev-help@openwhisk.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openwhisk.apache.org
From: Tyson Norris <tnorris@adobe.com.INVALID>
To: "dev@openwhisk.apache.org" <dev@openwhisk.apache.org>
Subject: PR feedback for SPIs
Thread-Topic: PR feedback for SPIs
Thread-Index: AQHTLFNjFDRIOWO8zkG6Xy9c9JHl4Q==
Date: Wed, 13 Sep 2017 05:44:39 +0000
Message-ID: <0DEC1B2C-B547-421F-AE58-EE2023F4AF0F@adobe.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: adobe.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_0DEC1B2CB547421FAE58EE2023F4AF0Fadobecom_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2017 05:44:39.4403
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: fa7b1b5a-7b34-4387-94ae-d2c178decee1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2470
archived-at: Wed, 13 Sep 2017 05:44:52 -0000

--_000_0DEC1B2CB547421FAE58EE2023F4AF0Fadobecom_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi -
Following SPI PRs need feedback (in order) , as interested people have time=
:

- LoadBalancer SPI - https://github.com/apache/incubator-openwhisk/pull/258=
4 - delegates loadbalancer creation to the SPI

- Multiple LoadBalancers SPI - https://github.com/apache/incubator-openwhis=
k/pull/2668 - allows multiple load balancers, loaded via the previous SPI, =
resolved per action via LoadBalancerResolver; allows either single loadbala=
ncer (current behavior) or kind based loadbalancer (config maps action kind=
s to a specific loadbalancer); this will allow things like latency sensitiv=
e actions routing to containers directly while latency insensitive actions =
route via Kafka, etc. Relies on previous

- ContainerFactory SPI - https://github.com/apache/incubator-openwhisk/pull=
/2659 - delegates container instantiation to an SPI; Affected areas are Inv=
okerReactive; also moved the dependent classes (Container et al) to common/=
scala, to allow for other cases (e.g. controller causes container launch, e=
tc); TBD: checking maxActiveContainers and maxPoolSize should be part of th=
is SPI too, but currently are not.  (e.g. maxActiveContainers may be dynami=
c with some cluster managers)

- LogStore SPI - https://github.com/apache/incubator-openwhisk/pull/2695 - =
enables log collection to be delegated to an decoupled system (instead of c=
onsuming cycles within the invoker JVM); Affected areas are ContainerProxy =
(log collection delegates to the SPI), RestAPIs (delegate log retrieval to =
the SPI), and ContainerFactory impls (delegate docker run --log-opt paramet=
ers to the SPI); still needs some cleanup (WIP). Relies on ContainerFactory=
, mostly since it organizes Container classes around the ones moved to comm=
on/scala


Building on these some upcoming additions include:
- direct LoadBalancer - allow controller to route actions directly to share=
d containers (i.e. to support better throughput with fewer containers, if t=
he action supports it, via multiple loadbalancers - one for kafka+invoker r=
outing, and one for direct container routing)
- mesos ContainerFactory - to support launching containers in a mesos clust=
er (run more containers with fewer, or just 1, invokers per cluster, since =
the invoker has access to the entire mesos cluster for container launching)


Let me know via comments in PR (or on dev list) if you have questions on th=
ese.

Thanks in advance for feedback!
Best
Tyson

--_000_0DEC1B2CB547421FAE58EE2023F4AF0Fadobecom_--