Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9144A200CE6 for ; Thu, 31 Aug 2017 16:44:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8FBDB16B3B2; Thu, 31 Aug 2017 14:44:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D86CF16B3B3 for ; Thu, 31 Aug 2017 16:44:45 +0200 (CEST) Received: (qmail 65790 invoked by uid 500); 31 Aug 2017 14:44:45 -0000 Mailing-List: contact commits-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list commits@openwhisk.apache.org Received: (qmail 65780 invoked by uid 99); 31 Aug 2017 14:44:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2017 14:44:45 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 6788481758; Thu, 31 Aug 2017 14:44:44 +0000 (UTC) Date: Thu, 31 Aug 2017 14:44:44 +0000 To: "commits@openwhisk.apache.org" Subject: [incubator-openwhisk-wskdeploy] branch master updated: Print warning msg when env var is empty (#419) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <150419068437.21788.17149283244641874060@gitbox.apache.org> From: mrutkowski@apache.org Reply-To: "commits@openwhisk.apache.org" X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-openwhisk-wskdeploy X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: ebc6add07b34e309ef80a48dbff27023b6f8c1b3 X-Git-Newrev: 5541d55de52885c983221d0b62131611c026c33f X-Git-Rev: 5541d55de52885c983221d0b62131611c026c33f X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated archived-at: Thu, 31 Aug 2017 14:44:46 -0000 This is an automated email from the ASF dual-hosted git repository. mrutkowski pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk-wskdeploy.git The following commit(s) were added to refs/heads/master by this push: new 5541d55 Print warning msg when env var is empty (#419) 5541d55 is described below commit 5541d55de52885c983221d0b62131611c026c33f Author: Ying Chun Guo AuthorDate: Thu Aug 31 22:44:42 2017 +0800 Print warning msg when env var is empty (#419) --- tests/usecases/triggerrule/manifest.yml | 2 +- utils/misc.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/usecases/triggerrule/manifest.yml b/tests/usecases/triggerrule/manifest.yml index 6c3ab3d..43615f2 100644 --- a/tests/usecases/triggerrule/manifest.yml +++ b/tests/usecases/triggerrule/manifest.yml @@ -1,5 +1,5 @@ package: - name: helloworld + name: triggerrule version: 1.0 license: Apache-2.0 actions: diff --git a/utils/misc.go b/utils/misc.go index eca40fe..91a2f72 100644 --- a/utils/misc.go +++ b/utils/misc.go @@ -159,8 +159,9 @@ func GetEnvVar(key interface{}) interface{} { envkey := strings.Split(key.(string), "$")[1] value := os.Getenv(envkey) if value == "" { - // TODO() We should issue a warning to the user (verbose) that env. var. was not found + // Issue a warning to the user (verbose) that env. var. was not found // (i.e., and empty string was returned). + fmt.Println("WARNING: Missing Environment Variable "+envkey+".") } return value } -- To stop receiving notification emails like this one, please contact ['"commits@openwhisk.apache.org" '].