openwhisk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lz1...@apache.org
Subject [incubator-openwhisk-wskdeploy] branch master updated: WIP: Update documentation on integration and unit tests. (#293)
Date Thu, 20 Jul 2017 05:33:27 GMT
This is an automated email from the ASF dual-hosted git repository.

lz1982 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk-wskdeploy.git


The following commit(s) were added to refs/heads/master by this push:
     new a67e728  WIP: Update documentation on integration and unit tests. (#293)
a67e728 is described below

commit a67e7285845828510c2c6c8849c950c37ca4576d
Author: Matt Rutkowski <mrutkows@us.ibm.com>
AuthorDate: Thu Jul 20 00:33:25 2017 -0500

    WIP: Update documentation on integration and unit tests. (#293)
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Create README.md
    
    * Add files via upload
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
    
    * Update documention on integration and unit tests.
---
 DEPENDENCIES.md                                    |   8 +++
 README.md                                          |  63 +++++++++++++--------
 deployers/servicedeployer.go                       |  26 +++++----
 .../OW-Programming-Model-Slides-Slide1.jpg         | Bin 0 -> 102157 bytes
 .../OW-Programming-Model-Slides-Slide2.jpg         | Bin 0 -> 131026 bytes
 .../diagrams/OW-Programming-Model-Slides.pptx      | Bin 0 -> 328908 bytes
 specification/diagrams/README.md                   |   1 +
 tests/README.md                                    |  52 +++++++++++------
 tests/usecases/helloworld/README.md                |  47 +++++++++++++--
 tests/usecases/triggerrule/README.md               |  23 ++++++--
 tests/usecases/webhook/README.md                   |  16 ++++--
 tests/usecases/webhook/deployment.yml              |   6 +-
 12 files changed, 172 insertions(+), 70 deletions(-)

diff --git a/DEPENDENCIES.md b/DEPENDENCIES.md
index 46059c0..d4d0405 100644
--- a/DEPENDENCIES.md
+++ b/DEPENDENCIES.md
@@ -7,3 +7,11 @@ list them here to assure that all code dependencies have Apache 2.0 compatible
l
 | ------| ------ | ------ |
 | jibber_jabber | Apache 2.0 | https://github.com/cloudfoundry-attic/jibber_jabber |
 | color | MIT | https://github.com/fatih/color |
+
+
+# Library dependencies for unit and integration testing
+
+| Library name | Licenses Type | License/Project Link |
+| ------| ------ | ------ |
+| Testify | ad-hoc (Liberal)| [https://github.com/stretchr/testify/blob/master/LICENCE.txt](https://github.com/stretchr/testify/blob/master/LICENCE.txt)
|
+| Viper | MIT | [https://github.com/spf13/viper/blob/master/LICENSE](https://github.com/spf13/viper/blob/master/LICENSE)
|
diff --git a/README.md b/README.md
index 859c66d..5274e74 100644
--- a/README.md
+++ b/README.md
@@ -6,46 +6,44 @@
 DISCLAIMER - wskdeploy is an experimental tool.
 -----------------------------------------------
 
+`wskdeploy` is a utility to help you create and deploy OpenWhisk packages and their entities
 using a Manifest file wrttien in YAML. Deploy all your Actions, Triggers, Rules and rules
using a single command! You can use this in addition to the OpenWhisk CLI.  In fact, this
utility uses the OpenWhisk "Go" CLI to create its HTTP REST calls for deploying and undeploying
your packages.
 
-`wskdeploy` is a utility to help you create and deploy OpenWhisk projects. Deploy all your
actions, triggers, and rules using a single command! You can use this in addition to the OpenWhisk
CLI.
-
-`wskdeploy` is currenty under development and in its very early stages.  Check back often
to see how its progressing.
-
-# How to use
+# How to run
 `wskdeploy` is written in Go. You can invoke it as a Go program, or run its binary file `wskdeploy`
directly after building.
 
-You can get the detail usage of this tool by using following commands:
+The following examples show you how to invoke wskdeploy's command line help using both methods,
as well as deploy the `triggerrule` test case:
 
+### Go program
+
+invoking command line help:
 ```
 $ go run main.go --help
 ```
 
-or
-
+deploying the ```triggerrule``` test case:
 ```
-$ ./wskdeploy --help
+$ go run main.go -m tests/usecases/triggerrule/manifest.yml -d tests/usecases/triggerrule/deployment.yml
 ```
 
-For example,
+### Binary file
 
+invoking command line help:
 ```
-$ go run main.go -m tests/usecases/triggerrule/manifest.yml -d tests/usecases/triggerrule/deployment.yml
+$ ./wskdeploy --help
 ```
 
-or
-
+deploying the ```triggerrule``` test case:
 ```
 $ ./wskdeploy -m tests/usecases/triggerrule/manifest.yml -d tests/usecases/triggerrule/deployment.yml
 ```
 
-will deploy the `triggerrule` test case.
-
 # Where to download the binary wskdeploy
+
 `wskdeploy` is available on the release page of openwhisk-wskdeploy project: [click here
to download](https://github.com/apache/incubator-openwhisk-wskdeploy/releases).
 We currently have binaries available for Linux, Mac OS and windows under amd64 architecture.
You can find the binary, which fits your local environment.
 
-
 # How to build on local host
+
 There is another approach to get the binary `wskdeploy`, which is to build it from the source
code with Go tool.
 
 Make sure `$GOPATH` is defined. If not, setup your [Go development environment](https://golang.org/doc/code.html).
@@ -78,17 +76,15 @@ You can verify your build by running:
 ./wskdeploy --help
 ```
 
-Note: we have no releases yet so you should build the `development` branch.
-
 # Contributing
 
-Start by creating a fork of `openwhisk-wskdeploy` and then change the git `origin` to point
to
-your forked repository, as follows:
+Start by creating a fork of `incubator-openwhisk-wskdeploy` and then change the git `origin`
to point to your forked repository, as follows:
 
-```sh
+```
 $ cd $GOPATH/src/github.com/apache/incubator-openwhisk-wskdeploy
 $ git remote rename origin upstream
 $ git remote add origin https://github.com/<your fork>/incubator-openwhisk-wskdeploy
+$ git fetch --all
 $ git branch --set-upstream-to origin/master  # track master from origin now
 ```
 
@@ -114,10 +110,31 @@ commands will start the wskdeploy cross compile for your specific OS
platform in
 
 7. After build success, you should find a correct binary under current /bin dir of you openwhisk-deploy
clone dir.
 
+# Debugging
+
+### Enable additional trace in Go client
+
+Wskdeploy uses the OpenWhisk Go Client to format and invoke OpenWhisk's APIs which has additional
debug tracing available.
+
+To enable this trace, set the following environemt variable in Bash:
+```
+# set to any value > 0
+WSK_CLI_DEBUG=1
+```
 
 # Known issues
 
-You might get this error when downloading `openwhisk-wskdeploy`
+### Git commands using HTTPS, not SSH
+
+The "go get" command uses HTTPS with GitHub and when you attempt to "commit" code you might
be prompted with your GitHub credentials.  If you wish to use your SSH credentials, you may
need to issue the following command to set the appropriate URL for your "origin" fork:
+
+```
+git remote set-url origin git@github.com:<username>/incubator-openwhisk-wskdeploy.git
+```
+
+### Git clone RPC failed: HTTP 301
+
+This sometimes occurs using "go get" the wskdeploy code (which indirectly invokes "git clone").
You might get this error when downloading `incubator-openwhisk-wskdeploy`:
 
      Cloning into ''$GOAPTH/src/gopkg.in/yaml.v2'...
      error: RPC failed; HTTP 301 curl 22 The requested URL returned error: 301
@@ -125,7 +142,7 @@ You might get this error when downloading `openwhisk-wskdeploy`
 
 This is caused by newer `git` not forwarding request anymore. One solution is to allow forwarding
for `gopkg.in`
 
-```sh
+```
 $ git config --global http.https://gopkg.in.followRedirects true
 ```
 
diff --git a/deployers/servicedeployer.go b/deployers/servicedeployer.go
index b7fe1fc..a235774 100644
--- a/deployers/servicedeployer.go
+++ b/deployers/servicedeployer.go
@@ -62,7 +62,8 @@ func NewDeploymentPackage() *DeploymentPackage {
 	return &dep
 }
 
-//ServiceDeployer defines a prototype service deployer.  It should do the following:
+// ServiceDeployer defines a prototype service deployer.
+// It should do the following:
 //   1. Collect information from the manifest file (if any)
 //   2. Collect information from the deployment file (if any)
 //   3. Collect information about the source code files in the working directory
@@ -77,7 +78,7 @@ type ServiceDeployer struct {
 	ManifestPath    string
 	ProjectPath     string
 	DeploymentPath  string
-	//whether to deploy the action under the package
+	// whether to deploy the action under the package
 	DeployActionInPackage bool
 	InteractiveChoice     bool
 	ClientConfig          *whisk.Config
@@ -165,7 +166,7 @@ func (deployer *ServiceDeployer) ConstructUnDeploymentPlan() (*DeploymentApplica
 	err = manifestReader.HandleYaml(deployer, manifestParser, manifest)
 	utils.Check(err)
 
-	// process deploymet file
+	// process deployment file
 	if utils.FileExists(deployer.DeploymentPath) {
 		var deploymentReader = NewDeploymentReader(deployer)
 		deploymentReader.HandleYaml()
@@ -178,8 +179,8 @@ func (deployer *ServiceDeployer) ConstructUnDeploymentPlan() (*DeploymentApplica
 	return verifiedPlan, nil
 }
 
-// Use relfect util to deploy everything in this service deployer
-// according some planning?
+// Use reflect util to deploy everything in this service deployer
+// TODO(TBD): according some planning?
 func (deployer *ServiceDeployer) Deploy() error {
 
 	if deployer.IsInteractive == true && !utils.Flags.WithinOpenWhisk {
@@ -305,7 +306,7 @@ func (deployer *ServiceDeployer) DeployPackages() error {
 	return nil
 }
 
-// DeployActions into OpenWhisk
+// Deploy Sequences into OpenWhisk
 func (deployer *ServiceDeployer) DeploySequences() error {
 
 	for _, pack := range deployer.Deployment.Packages {
@@ -316,7 +317,7 @@ func (deployer *ServiceDeployer) DeploySequences() error {
 	return nil
 }
 
-// DeployActions into OpenWhisk
+// Deploy Actions into OpenWhisk
 func (deployer *ServiceDeployer) DeployActions() error {
 
 	for _, pack := range deployer.Deployment.Packages {
@@ -437,8 +438,9 @@ func (deployer *ServiceDeployer) createFeedAction(trigger *whisk.Trigger,
feedNa
 func (deployer *ServiceDeployer) createRule(rule *whisk.Rule) {
 	// The rule's trigger should include the namespace with pattern /namespace/trigger
 	rule.Trigger = deployer.getQualifiedName(rule.Trigger.(string), deployer.ClientConfig.Namespace)
-	// The rule's action should include the namespace and package with pattern /namespace/package/action
-	// please refer https://github.com/openwhisk/openwhisk/issues/1577
+	// The rule's action should include the namespace and package
+	// with pattern /namespace/package/action
+	// TODO(TBD): please refer https://github.com/openwhisk/openwhisk/issues/1577
 
 	// if it contains a slash, then the action is qualified by a package name
 	if strings.Contains(rule.Action.(string), "/") {
@@ -464,7 +466,7 @@ func (deployer *ServiceDeployer) createRule(rule *whisk.Rule) {
 
 // Utility function to call go-whisk framework to make action
 func (deployer *ServiceDeployer) createAction(pkgname string, action *whisk.Action) error
{
-	// call ActionService Thru Client
+	// call ActionService through the Client
 	if deployer.DeployActionInPackage {
 		// the action will be created under package with pattern 'packagename/actionname'
 		action.Name = strings.Join([]string{pkgname, action.Name}, "/")
@@ -480,7 +482,7 @@ func (deployer *ServiceDeployer) createAction(pkgname string, action *whisk.Acti
 	return nil
 }
 
-// create api gateway
+// create api (API Gateway functionality)
 func (deployer *ServiceDeployer) createApi(api *whisk.ApiCreateRequest) {
 	_, _, err := deployer.Client.Apis.Insert(api, nil, true)
 	if err != nil {
@@ -517,7 +519,7 @@ func (deployer *ServiceDeployer) UnDeploy(verifiedPlan *DeploymentApplication)
e
 
 		} else {
 			deployer.InteractiveChoice = false
-			fmt.Println("OK. Cancelling undeployment")
+			fmt.Println("OK. Canceling undeployment")
 			return nil
 		}
 	}
diff --git a/specification/diagrams/OW-Programming-Model-Slides-Slide1.jpg b/specification/diagrams/OW-Programming-Model-Slides-Slide1.jpg
new file mode 100644
index 0000000..b0130b2
Binary files /dev/null and b/specification/diagrams/OW-Programming-Model-Slides-Slide1.jpg
differ
diff --git a/specification/diagrams/OW-Programming-Model-Slides-Slide2.jpg b/specification/diagrams/OW-Programming-Model-Slides-Slide2.jpg
new file mode 100644
index 0000000..4f9cc1e
Binary files /dev/null and b/specification/diagrams/OW-Programming-Model-Slides-Slide2.jpg
differ
diff --git a/specification/diagrams/OW-Programming-Model-Slides.pptx b/specification/diagrams/OW-Programming-Model-Slides.pptx
new file mode 100644
index 0000000..3a5bb24
Binary files /dev/null and b/specification/diagrams/OW-Programming-Model-Slides.pptx differ
diff --git a/specification/diagrams/README.md b/specification/diagrams/README.md
new file mode 100644
index 0000000..76124c5
--- /dev/null
+++ b/specification/diagrams/README.md
@@ -0,0 +1 @@
+# Specification diagram source files
diff --git a/tests/README.md b/tests/README.md
index 3f73d84..88fa527 100644
--- a/tests/README.md
+++ b/tests/README.md
@@ -1,9 +1,7 @@
 # Test cases for openwhisk-wskdeploy.
 
-There are two types of test cases located under the folder of tests: unit and integration.
You can identify
-them by the first line of each test case file. Unit tests are tagged with "+build unit" and
integration tests
-are tagged with "+build integration". For example, the test file deploymentreader_test.go
under
-tests/src/deployers contains unit test cases, so it is indicated with the unit tag on the
top of the file:
+There are two types of test cases located under the 'tests': unit and integration. You can
identify them by the first line of each test case file. Unit tests are tagged with "+build
unit" and integration tests are tagged with "+build integration". For example, the test file
deploymentreader_test.go under tests/src/deployers contains unit test cases, so it is indicated
with the unit tag on the top of the file:
+
 ```
 // +build unit
 
@@ -19,33 +17,53 @@ package tests
 ...
 ```
 
-# How to run the tests
-You need to install the package Testify before running the test cases:
+# How to run wskdeploy tests
+
+Before running unit or integration tests, you need to install the package [Testify](https://github.com/stretchr/testify/)
before running the test cases:
 ```
 cd $GOPATH
 go get -u github.com/stretchr/testify
 
 ```
 
-Then you are able to run all the unit tests via the following command under the folder of
openwhisk-wkdeploy:
+## Running unit tests
+
+After installing Testify, all the unit tests can be run from the main 'incubator-openwhisk-wskdeploy'
repository folder using the following command:
+
 ```
 $ go test -v ./... -tags unit
 ```
 
-In order to run all the integration tests, run the following command under the folder of
openwhisk-wkdeploy:
+## Running integration tests
+
+After installing Testify, all integration tests can be run rom the main 'incubator-openwhisk-wskdeploy'
repository folder using the following command:
+
 ```
 $ go test -v ./... -tags integration
 ```
 
 # How to structure the test cases
-All the test cases are put under the folder tests/src, and all the integration test cases
are put under
-the folder tests/src/integration.
 
-Different unit tests can be grouped into different packages, and they can be put under a
subfolder
-named after the package under tests/src. The yaml files of manifest and deployment used by
unit tests are
-put under tests/data.
+All integration test cases are put under the folder 'tests/src/integration'.
+
+Unit tests are co-located in the same directory as the package they are testing (by Go convention).
The test files would use the same basename as the file that containst the package they are
providing tests for but with and add '_test' postfix.
+
+For example, the package 'deployers', which defines a 'DeploymentReader' service, is declared
in the file 'deploymentreader.go'; its corresponding unit test is in the file named 'deploymentreader_test.go'
in the same directory.
+
+## Grouping tests
+
+Additional unit tests can be grouped into different packages, and they can be put under a
subfolder
+named after the package under 'tests/src'. The yaml files of manifest and deployment used
by unit tests are put under 'tests/data'.
+
+Different integration tests can be grouped into different packages as well, and they can
be put under a subfolder named after the package under 'tests/src/integration'. The yaml files
of manifest and deployment used by the integration test are put under the same subfolder as
the integration test itself. The source file used by the manifest file can be put under the
folder 'tests/src/integration/<package>/src'.
+
+# Unit test listing
 
-Different integration tests can be grouped into different packages as well, and they can
be put under a
-subfolder named after the package under tests/src/integration. The yaml files of manifest
and deployment
-used by the integration test are put under the same subfolder as the integration test itself.
The source
-file used by the manifest file can be put under the folder tests/src/integration/<package>/src.
+| Test File | Manifest | Deployment | Description |
+| ------| ------ | ------ | ------ |
+| [deployers / deploymentreader_test.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/deployers/deploymentreader_test.go)
| usecases/badyaml/manifest.yaml | usecases/badyaml/deployment.yaml| Tests DeploymentReader
service. |
+| [deployers / manifestreader_test.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/deployers/manifestreader_test.go)
| dat/manifest6.yaml | N/A | Tests ManifestReader service |
+| [utils / utils_test.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/utils/util_test.go)
| N/A | dat/deployment.yaml| Tests ContentReader, ReadUrl |
+| [cmd / root_test.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/cmd/root_test.go)
| N/A | N/A | Tests Cobra frameworks "Root" command (i.e., "wskdeploy") and its child commands|
+| [parsers / yamlparser_test.go](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/parsers/yamlparser_test.go)
| usecases/helloworld/manifest.yaml, dat/manifest1.yaml, dat/manifest2.yaml, dat/manifest3.yaml,
dat/manifest4.yaml, dat/manifest5.yaml, dat/manifest6.yaml | dat/deploy1.yaml, dat/deploy2.yaml,
dat/deploy3.yaml, dat/deploy4.yaml | Tests YAML parser against various Manifest and Deployment
files. |
+<!-- | []() | <manifest> | <depl> | <desc> | -->
diff --git a/tests/usecases/helloworld/README.md b/tests/usecases/helloworld/README.md
index afcb580..7e8e21d 100644
--- a/tests/usecases/helloworld/README.md
+++ b/tests/usecases/helloworld/README.md
@@ -1,8 +1,47 @@
-# Test case for Whisk Deploy
+# "helloworld" test case for wskdeploy.
 
-This is a test case for wskdeploy. There is an action named as "hello" in this package. It
accepts two parameters "name" and "place" and will return a greeting message "Hello, name
from place!"
+### Package description
 
-It can be tested as below:
-$ wskdeploy -p tests/testcases/helloworld
+The [manifest.yaml](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/tests/usecases/helloworld/manifest.yaml)
file defines:
+
+- a Package named "helloworld" which contains two Actions:
+    - an Action named "hello"
+    - an Action named "helloworld"
+    - Two optional triggers "trigger1" and "trigger2"
+
+Both the "hello" and "helloworld" Actions accept the same two parameters:
+    - "name" (string)
+    - "place" (string)
+
+The "hello" Action has the following defaults for these properties:
+    - name: Paul
+    - place Boston
+
+The "helloworld" Action has the following defaults for these properties:
+    - name: Bernie
+    - place Vermont
+
+and will return a greeting message:
+
+```
+"Hello, <name> from <place>!"
+```
+
+### How to deploy and test
+
+Step 1. Deploy the package.
+
+Deploy it using the  ```wskdeploy``` command as follows using the manifest.yaml file found
in the "path" indicated on the '-p' command line option:
+```
+$ wskdeploy -p tests/usecases/helloworld
+```
+
+Step 2. Verify the actions were created.
+```
 $ wsk action list
+```
+
+Step 3. Invoke the action.
+```
 $ wsk action invoke --blocking --result helloworld/hello --param name Bernie --param place
Vermont
+```
diff --git a/tests/usecases/triggerrule/README.md b/tests/usecases/triggerrule/README.md
index dd51c09..c1eed78 100644
--- a/tests/usecases/triggerrule/README.md
+++ b/tests/usecases/triggerrule/README.md
@@ -1,25 +1,36 @@
-# Test case for WskTool.
+# TriggerRule use case for wskdeploy
 
-This is a test case for WskTool. The package includes:
+### Package description
+
+The package includes:
 - An action named as "hello". It accepts two parameters "name" and "place" and will return
a greeting message "Hello, name from place!"
 - A trigger named as "locationUpdate"
 - A rule to associate the trigger with the action.
 
-It can be tested as below:
-Step 1. Deploy the package.
-$ wsktool deploy -p /tests/testcases/helloworld
+### How to deploy and test
 
+Step 1. Deploy the package.
+```
+$ wskdeploy -p /tests/usecases/helloworld
+```
 Step 2. Verify the action is installed.
+```
 $ wsk action list
+```
 
 Step 3. Verify the action is invoked.
+```
 $ wsk activation list --limit 1 hello
 $ wsk activation result <your action ID>
+```
 
 Step 4. Invoke the trigger
+``
 $ wsk trigger fire locationUpdate --param name Bernie --param place "Washington, D.C."
+```
 
 Step 5. Verify the action is invoked
+```
 $ wsk activation list --limit 1 hello
 $ wsk activation result <your action ID>
-
+```
diff --git a/tests/usecases/webhook/README.md b/tests/usecases/webhook/README.md
index cfaef8a..96cc0af 100644
--- a/tests/usecases/webhook/README.md
+++ b/tests/usecases/webhook/README.md
@@ -1,6 +1,8 @@
-# Test case for WskTool.
+# WebHook test case for wskdeploy
 
-This is a test case for WskDeploy tool. The package manifest file includes:
+### Package description
+
+The package manifest file includes:
 - An action named as `webhook` which will register a webhook in a specific github repository.
The url of `webhook_trigger` is set as the webhook's configured URL. When one of the specified
events is happened, a HTTP POST payload will be sent to the webhook's configured URL, i.e.
the `webhook_trigger` URL.
 - A feed named as `webhook_feed` which is a FEED ACTION by setting the field `action` as
an action name `webhook`.
 - A trigger named as `webhook_trigger`, whose URL is set as the webhook's configured URL.
@@ -15,16 +17,20 @@ The package deployment file includes:
  - events: the event of github,seperated by comma e.g. `fork`, `push`. The full list can
be found [here](https://developer.github.com/webhooks/#events).
  - endpoint: the name or IP address of the OpenWhisk server where the package is deployed.
 
-It can be tested as below:
+### How to deploy and test
+
 Step 1. Update the parameters in deployment.yml to the correct values
 
 Step 2. Deploy the package.
-$ wsktool deploy -p /tests/testcases/webhook
+```
+$ wskdeploy -p /tests/usecases/webhook
+```
 
 Step 3. Verify the action is installed.
+```
 $ wsk action list
+```
 
 Step 4. Trigger the event configured in deployment.yml
 
 Step 5. Verify the trigger is invoked
-
diff --git a/tests/usecases/webhook/deployment.yml b/tests/usecases/webhook/deployment.yml
index 512ac9b..1f6f4b6 100644
--- a/tests/usecases/webhook/deployment.yml
+++ b/tests/usecases/webhook/deployment.yml
@@ -10,10 +10,10 @@ application:
         webhook:
           #we treat the inputs as parameters besides --feed.
           inputs:
-            username: daisy-ycguo 
+            # TODO(dliu): Please fix "repsotiory value" and see if we can change/remove username
+            # as actual developer names should not be in these files when possible.
+            username: daisy-ycguo
             repository: https://github.com/openwhisk/wsktool.git
             accessToken:
             events: PUSH
             endpoint: openwhisk.ng.bluemix.net
-
-

-- 
To stop receiving notification emails like this one, please contact
['"commits@openwhisk.apache.org" <commits@openwhisk.apache.org>'].

Mime
View raw message