openwhisk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cbic...@apache.org
Subject [incubator-openwhisk] branch master updated: Remove ContainerPool test which is no longer applicable.
Date Wed, 19 Jul 2017 09:36:53 GMT
This is an automated email from the ASF dual-hosted git repository.

cbickel pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk.git


The following commit(s) were added to refs/heads/master by this push:
     new 742ab2d  Remove ContainerPool test which is no longer applicable.
742ab2d is described below

commit 742ab2df1df7cadecb75d22b9e63a2225e4d560f
Author: Markus Thoemmes <markus.thoemmes@de.ibm.com>
AuthorDate: Wed Jul 19 08:35:50 2017 +0200

    Remove ContainerPool test which is no longer applicable.
    
    This test used to test a situation of self-recovery in case the ActivationFeed sends more
messages than the ContainerPool can consume. This has been deemed an error situation and would
be a bug in the ActivationFeed, hence the log is flooded with error messages.
---
 .../core/containerpool/test/ContainerPoolTests.scala    | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala b/tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
index 5202ef8..1988888 100644
--- a/tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
+++ b/tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
@@ -195,23 +195,6 @@ class ContainerPoolTests extends TestKit(ActorSystem("ContainerPool"))
         containers(1).expectMsg(runMessageDifferentNamespace)
     }
 
-    it should "not remove a container to make space in the pool if it is already full and
the same action + same invocation namespace arrives" in within(timeout) {
-        val (containers, factory) = testContainers(2)
-        val feed = TestProbe()
-
-        // a pool with only 1 slot
-        val pool = system.actorOf(ContainerPool.props(factory, 1, 1, feed.ref))
-        pool ! runMessage
-        containers(0).expectMsg(runMessage)
-        containers(0).send(pool, NeedWork(warmedData()))
-        feed.expectMsg(MessageFeed.Processed)
-        pool ! runMessage
-        containers(0).expectMsg(runMessage)
-        pool ! runMessage //expect this message to be requeued since previous is incomplete.
-        containers(0).expectNoMsg(100.milliseconds)
-        containers(1).expectNoMsg(100.milliseconds)
-    }
-
     /*
      * CONTAINER PREWARMING
      */

-- 
To stop receiving notification emails like this one, please contact
['"commits@openwhisk.apache.org" <commits@openwhisk.apache.org>'].

Mime
View raw message