Mailing-List: contact dev-help@openwebbeans.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openwebbeans.apache.org
Received-SPF: pass (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type;
  b=10wFM8bM/Bm052ViTWCPJm8MO1j7U+IFJYjqv53Y2Tnutm3b+/REp3l5PuSPvOSkA+p2VNCMAQ/mL4pqfhLaEqFe817Qnhw/m80uxh2Q47Csny6R/bgMAFO1AY60gpyfXCsI0jYWfJW0oDEXsmoke+zonz9lqyrZ13A7PuS3ZHI=;
References: <20121115122518.9E8A22388900@eris.apache.org>
  <1352985055.83944.YahooMailNeo@web28901.mail.ir2.yahoo.com>
Message-ID: <1352985415.73998.YahooMailNeo@web121502.mail.ne1.yahoo.com>
Date: Thu, 15 Nov 2012 05:16:55 -0800 (PST)
From: Gurkan Erdogdu <gurkanerdogdu@yahoo.com>
Reply-To: Gurkan Erdogdu <gurkanerdogdu@yahoo.com>
Subject: Re: svn commit: r1409751 - in
 /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/proxy:
 ProxyFactory.java javassist/JavassistFactory.java
To: "dev@openwebbeans.apache.org" <dev@openwebbeans.apache.org>
In-Reply-To: <1352985055.83944.YahooMailNeo@web28901.mail.ir2.yahoo.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="1319493512-116892990-1352985415=:73998"

--1319493512-116892990-1352985415=:73998
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hey Mark=0A=0A=0AI don't think to create JIRA issues for every commit.=C2=
=A0 I think that this is not a big change, this method is not used in anywh=
ere in the codebase and only used for EJB purposes. Someone removed this co=
de while removing Javassist functionality and introduces regression. Sure t=
o always open for a big changes!=0A=0A=0AGurkan=0A=0A=0A=0A________________=
________________=0A Kimden: Mark Struberg <struberg@yahoo.de>=0AKime: "dev@=
openwebbeans.apache.org" <dev@openwebbeans.apache.org> =0AG=C3=B6nderildi=
=C4=9Fi Tarih: 15 Kas=C4=B1m 2012 15:10 Per=C5=9Fembe=0AKonu: Re: svn commi=
t: r1409751 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache=
/webbeans/proxy: ProxyFactory.java javassist/JavassistFactory.java=0A =0AGu=
rkan, please create a JIRA for all other than cosmetical changes!=0AThis is=
 a pretty big change internally and really requires a JIRA entry.=0A=0Atxs =
and LieGrue,=0Astrub=0A=0A=0A=0A----- Original Message -----=0A> From: "ger=
dogdu@apache.org" <gerdogdu@apache.org>=0A> To: commits@openwebbeans.apache=
.org=0A> Cc: =0A> Sent: Thursday, November 15, 2012 1:25 PM=0A> Subject: sv=
n commit: r1409751 - in /openwebbeans/trunk/webbeans-impl/src/main/java/org=
/apache/webbeans/proxy: ProxyFactory.java javassist/JavassistFactory.java=
=0A> =0A> Author: gerdogdu=0A> Date: Thu Nov 15 12:25:17 2012=0A> New Revis=
ion: 1409751=0A> =0A> URL: http://svn.apache.org/viewvc?rev=3D1409751&view=
=3Drev=0A> Log:=0A> Regression in Javassist remove updates=0A> =0A> Modifie=
d:=0A> =C2=A0 =C2=A0 =0A> openwebbeans/trunk/webbeans-impl/src/main/java/or=
g/apache/webbeans/proxy/ProxyFactory.java=0A> =C2=A0 =C2=A0 =0A> openwebbea=
ns/trunk/webbeans-impl/src/main/java/org/apache/webbeans/proxy/javassist/Ja=
vassistFactory.java=0A> =0A> Modified: =0A> openwebbeans/trunk/webbeans-imp=
l/src/main/java/org/apache/webbeans/proxy/ProxyFactory.java=0A> URL: =0A> h=
ttp://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/=
org/apache/webbeans/proxy/ProxyFactory.java?rev=3D1409751&r1=3D1409750&r2=
=3D1409751&view=3Ddiff=0A> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A> --- =0A> openwebbeans/trunk/webbea=
ns-impl/src/main/java/org/apache/webbeans/proxy/ProxyFactory.java =0A> (ori=
ginal)=0A> +++ =0A> openwebbeans/trunk/webbeans-impl/src/main/java/org/apac=
he/webbeans/proxy/ProxyFactory.java =0A> Thu Nov 15 12:25:17 2012=0A> @@ -2=
2,6 +22,7 @@ import java.io.Serializable;=0A> import java.lang.reflect.Cons=
tructor;=0A> import java.lang.reflect.InvocationTargetException;=0A> import=
 java.lang.reflect.Type;=0A> +import java.util.ArrayList;=0A> import java.u=
til.HashSet;=0A> import java.util.Iterator;=0A> import java.util.List;=0A> =
@@ -106,12 +107,60 @@ public final class ProxyFactory=0A> =C2=A0 =C2=A0 =C2=
=A0 */=0A> =C2=A0 =C2=A0=C2=A0 public Class<?> getEjbBeanProxyClass(OwbBean=
<?> bean, =0A> Class<?> iface)=0A> =C2=A0 =C2=A0=C2=A0 {=0A> +=C2=A0 =C2=A0=
 =C2=A0 =C2=A0 Class<?> proxyClass =3D null;=0A> +=0A> =C2=A0 =C2=A0 =C2=A0=
 =C2=A0=C2=A0 ConcurrentMap<Class<?>, Class<?>> typeToProxyClassMap =0A> =
=3D ejbProxyClasses.get(bean);=0A> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (typeToP=
roxyClassMap !=3D null)=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (typeToProxyCla=
ssMap =3D=3D null)=0A> =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 {=0A> -=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return typeToProxyClassMap.get(iface);=0A> =
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 typeToProxyClassMap =3D new Conc=
urrentHashMap<Class<?>, =0A> Class<?>>();=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 ConcurrentMap<Class<?>, Class<?>> existingMap =3D =0A> ejbPro=
xyClasses.putIfAbsent(bean, typeToProxyClassMap);=0A> +=C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // us=
e the map that beat us, because our new one definitely had no =0A> classes =
in it.=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 typeToProxyClassMap =
=3D (existingMap !=3D null) ? existingMap : =0A> typeToProxyClassMap; =0A> =
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 }=0A> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 return=
 null;=0A> +=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 proxyClass =3D typeToProxyCla=
ssMap.get(iface);=0A> +=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (proxyClass =3D=
=3D null)=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 {=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 Class<?> superClazz =3D null;=0A> +=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 List<Class<?>> list =3D new =0A> ArrayList<Class<?>>()=
;=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Class<?>[] interfaces =3D =
null;=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =0A> +=C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (iface.isInterface())=0A> +=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 {=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 list.add(iface);=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 }=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else =0A> +=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 // @LocalBean no-interface local view requested=0A> +=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 superClazz =3D ifac=
e;=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 //Stateless=
 beans with no interface=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 //To failover bean instance=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 Class<?>[] ifaces =3D iface.getInterfaces();=0A> +=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if(ifaces !=3D null=
 && ifaces.length > 0)=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 {=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 //check for serializable=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for(Class<?> temp : ifaces)=0A> +=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {=0A> +=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 if(temp =3D=3D Serializable.class)=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {=0A> +=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 list.add(Serializable.class);=0A> +=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 break;=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 }=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 }=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 interfaces =3D new =
Class<?>[list.size()];=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 inter=
faces =3D list.toArray(interfaces);=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 proxyClass =3D factory.getProxyClass(superClazz, interfaces);=0A> +=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 typeToProxyClassMap.putIfAbsent(iface, proxyClass);=0A> +=C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 // don't care if we were beaten in u=
pdating the =0A> iface->proxyclass map=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 }=
=0A> +=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return proxyClass;=0A> =C2=A0 =C2=
=A0=C2=A0 }=0A> =C2=A0 =C2=A0 =0A> =C2=A0 =C2=A0=C2=A0 public Object create=
DecoratorDelegate(OwbBean<?> bean, =0A> DelegateHandler newDelegateHandler)=
=0A> =0A> Modified: =0A> openwebbeans/trunk/webbeans-impl/src/main/java/org=
/apache/webbeans/proxy/javassist/JavassistFactory.java=0A> URL: =0A> http:/=
/svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/a=
pache/webbeans/proxy/javassist/JavassistFactory.java?rev=3D1409751&r1=3D140=
9750&r2=3D1409751&view=3Ddiff=0A> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A> --- =0A> openwebbeans/tru=
nk/webbeans-impl/src/main/java/org/apache/webbeans/proxy/javassist/Javassis=
tFactory.java =0A> (original)=0A> +++ =0A> openwebbeans/trunk/webbeans-impl=
/src/main/java/org/apache/webbeans/proxy/javassist/JavassistFactory.java =
=0A> Thu Nov 15 12:25:17 2012=0A> @@ -38,7 +38,10 @@ public class Javassist=
Factory=0A> =C2=A0 =C2=A0=C2=A0 {=0A> =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 Pro=
xyFactory fact =3D new ProxyFactory();=0A> =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=
=A0 fact.setInterfaces(interfaces);=0A> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 fact.s=
etSuperclass(superClass);=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if(superClass !=
=3D null)=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 {=0A> +=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 fact.setSuperclass(superClass);=C2=A0 =0A> +=C2=A0 =C2=A0=
 =C2=A0 =C2=A0 }=0A> =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 fact.setFilter(Final=
izeMethodFilter.INSTANCE);=0A> =0A> =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 retur=
n getProxyClass(fact);=0A>
--1319493512-116892990-1352985415=:73998--