openwebbeans-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Struberg <strub...@yahoo.de>
Subject Re: Re: heavy cleanup
Date Mon, 26 Nov 2012 19:46:45 GMT
Hi Jean-Louis!

Imo the most important thing is to check all our Beans and other 'static' information which
gets created at boot time if it contains some state data like the CreationalContext! I already
removed a few public ThreadLocals and isolated a CreationalContext in the base Producer implementation
(we must fix this in owb-1.1.7 as well btw!) and are currently thinking about how we can solve
this problem.

There is also quite a few other state data which get's currently passed via ThreadLocals which
is not really nice. Maybe we can move this to the CreationalContext as well...


LieGrue,
strub




----- Original Message -----
> From: Jean-Louis MONTEIRO <jeanouii@gmail.com>
> To: dev@openwebbeans.apache.org
> Cc: 
> Sent: Monday, November 26, 2012 3:15 PM
> Subject: Re: Re: heavy cleanup
> 
>T hat's all perfect Mark.
> Thanks for the answer.
> 
> Any Jira we could work on?
> 
> 
> 2012/11/26 Mark Struberg <struberg@yahoo.de>
> 
>> 
>> 
>>  yes, either I ger commit right or I will copy them over to owb and later
>>  move them back.
>>  There is lots of documentation needed as well.
>> 
>>  LieGrue,
>>  strub
>> 
>>  ------------------------------
>>  David Jencks schrieb am So., 25. Nov 2012 17:41 PST:
>> 
>>  >Quite a while back I set up a project at geronimo specs for the 1.1 
> spec
>>  classes, are there changes in any of the classes?
>>  >
>>  >thanks
>>  >david jencks
>>  >
>>  >On Nov 25, 2012, at 11:36 AM, Mark Struberg wrote:
>>  >
>>  >> I again found a heavy bug which is caused by things like
>>  >>
>>  >>
>>  >>     //X TODO this MUST NOT be public!
>>  >>     public static 
> ThreadLocal<List<DependentCreationalContext<Object>>
>>  dependentInstanceOfProducerMethods =
>>  >>         new 
> ThreadLocal<List<DependentCreationalContext<Object>>();
>>  >>
>>  >>
>>  >> Such code is pure PITA!
>>  >>
>>  >>
>>  >> I'm really tempted to do a heavy cleanup in 1.2.0 (trunk) and 
> go for
>>  CDI-1.1 directly. The spec is good enough to give a rough direction atm and
>>  we really need to cleanup tons of things!
>>  >>
>>  >> LieGrue,
>>  >> strub
>>  >
>> 
>> 
>> 
>> 
>> 
> 
> 
> -- 
> Jean-Louis
> 

Mime
View raw message