From commits-return-7332-archive-asf-public=cust-asf.ponee.io@openwebbeans.apache.org Sat Apr 28 20:50:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DEDE2180649 for ; Sat, 28 Apr 2018 20:50:55 +0200 (CEST) Received: (qmail 3208 invoked by uid 500); 28 Apr 2018 18:50:55 -0000 Mailing-List: contact commits-help@openwebbeans.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwebbeans.apache.org Delivered-To: mailing list commits@openwebbeans.apache.org Received: (qmail 3197 invoked by uid 99); 28 Apr 2018 18:50:55 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 28 Apr 2018 18:50:55 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 0983C3A009D for ; Sat, 28 Apr 2018 18:50:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1830468 - /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java Date: Sat, 28 Apr 2018 18:50:53 -0000 To: commits@openwebbeans.apache.org From: struberg@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20180428185054.0983C3A009D@svn01-us-west.apache.org> Author: struberg Date: Sat Apr 28 18:50:53 2018 New Revision: 1830468 URL: http://svn.apache.org/viewvc?rev=1830468&view=rev Log: OWB-1243 no need to filter for async for Lifecycle events Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1830468&r1=1830467&r2=1830468&view=diff ============================================================================== --- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java (original) +++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java Sat Apr 28 18:50:53 2018 @@ -676,14 +676,18 @@ public final class NotificationManager LinkedList> observerMethods = new LinkedList<>(resolveObservers(event, metadata, isLifecycleEvent)); - // filter for all async or all synchronous observermethods - // oldschool and not Streams, because of performance and avoiding tons of temporary objects - Iterator> observerMethodIterator = observerMethods.iterator(); - while (observerMethodIterator.hasNext()) + // async doesn't apply to Extension lifecycle events + if (!isLifecycleEvent) { - if (async != observerMethodIterator.next().isAsync()) + // filter for all async or all synchronous observermethods + // oldschool and not Streams, because of performance and avoiding tons of temporary objects + Iterator> observerMethodIterator = observerMethods.iterator(); + while (observerMethodIterator.hasNext()) { - observerMethodIterator.remove(); + if (async != observerMethodIterator.next().isAsync()) + { + observerMethodIterator.remove(); + } } }