Return-Path: 
 <commits-return-4377-apmail-openwebbeans-commits-archive=openwebbeans.apache.org@openwebbeans.apache.org>
X-Original-To: apmail-openwebbeans-commits-archive@www.apache.org
Delivered-To: apmail-openwebbeans-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BA2DA11DF8
	for <apmail-openwebbeans-commits-archive@www.apache.org>;
 Wed, 10 Sep 2014 18:57:15 +0000 (UTC)
Received: (qmail 90084 invoked by uid 500); 10 Sep 2014 18:57:15 -0000
Delivered-To: apmail-openwebbeans-commits-archive@openwebbeans.apache.org
Received: (qmail 90059 invoked by uid 500); 10 Sep 2014 18:57:15 -0000
Mailing-List: contact commits-help@openwebbeans.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@openwebbeans.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@openwebbeans.apache.org>
List-Post: <mailto:commits@openwebbeans.apache.org>
List-Id: <commits.openwebbeans.apache.org>
Reply-To: dev@openwebbeans.apache.org
Delivered-To: mailing list commits@openwebbeans.apache.org
Received: (qmail 90036 invoked by uid 99); 10 Sep 2014 18:57:15 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 18:57:14 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of rmannibucau@gmail.com
 designates 209.85.216.174 as permitted sender)
Received: from [209.85.216.174] (HELO mail-qc0-f174.google.com)
 (209.85.216.174)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Sep 2014 18:57:11 +0000
Received: by mail-qc0-f174.google.com with SMTP id m20so139900qcx.5
        for <multiple recipients>; Wed, 10 Sep 2014 11:56:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=oAuYnsoYa1uTNOY/3Q3eGkZFITtLI6J4qZ59NtmY5E8=;
        b=qo9qH8Gl+KKsHXuqC/4yUFv6tVEuu6Vw3XNKxC7qbT67Wjq0+Cnmgi2rVgW0LE8H5N
         wmzLhz8CsblksYQIcXHgrbZjj0yudJ1zvYVLSdaOQpSGpw+KGpo6AIoXPAfbn9wB3ko6
         +Lfd4H9C+qmDYHNe9c7S8qSIXDJb1wUjApA3bnLo4X3ecNSScD+JRi9Aatj3u4Wg4Ruv
         Q29Bu4UraHJkxygoNEbGwD4WHUEHec57uVebyiQf4fCysSCSmDf+yh5mMp4HQP1Xx4Do
         SNH7Sv28jQJaNouHGjl5Odgp2yuL9/PRnCay2UzRA21j3y46T5FxByfm4raajs0sjizD
         K04A==
X-Received: by 10.140.92.97 with SMTP id a88mr43455340qge.85.1410375410452;
 Wed, 10 Sep 2014 11:56:50 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.96.81.228 with HTTP; Wed, 10 Sep 2014 11:56:30 -0700 (PDT)
In-Reply-To: <1410375214.42224.YahooMailNeo@web28906.mail.ir2.yahoo.com>
References: <20140910184538.9904C2388999@eris.apache.org>
 <1410375214.42224.YahooMailNeo@web28906.mail.ir2.yahoo.com>
From: Romain Manni-Bucau <rmannibucau@gmail.com>
Date: Wed, 10 Sep 2014 20:56:30 +0200
Message-ID: 
 <CACLE=7M+7bzZSA1vD6MMB-XB_WQhDPZ0hWWju-xoGBWasxnXJA@mail.gmail.com>
Subject: Re: svn commit: r1624094 -
 /openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
To: openwebbeans-dev <dev@openwebbeans.apache.org>,
 Mark Struberg <struberg@yahoo.de>
Cc: "commits@openwebbeans.apache.org" <commits@openwebbeans.apache.org>
Content-Type: text/plain; charset=UTF-8
X-Virus-Checked: Checked by ClamAV on apache.org

dont get your comment, this is not this method, this one is the
default one (void addAnnotatedType(AnnotatedType<?> type))

By tck this one can't reuse default key

the value is just a unique generated one. We should enhance for sure
but technically it seems ok


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-09-10 20:53 GMT+02:00 Mark Struberg <struberg@yahoo.de>:
> romain, the key is enough. the ID given to addAnnotatedType  must NOT get changed.
>
> A user can use this key to identify his own SyntheticAnnoatedTypes later...
>
> LieGrue,
> strub
>
>
>
> On Wednesday, 10 September 2014, 20:46, "rmannibucau@apache.org" <rmannibucau@apache.org> wrote:
>
>
>>
>>
>>Author: rmannibucau
>>Date: Wed Sep 10 18:45:38 2014
>>New Revision: 1624094
>>
>>URL: http://svn.apache.org/r1624094
>>Log:
>>id are better when unique ;), todo: surely remove AnnotatedElementFactory.OWB_DEFAULT_KEY, and surely use same algo as in toString of OwbBeans (keeping extension class in the id)
>>
>>Modified:
>>    openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>
>>Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java
>>URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java?rev=1624094&r1=1624093&r2=1624094&view=diff
>>==============================================================================
>>--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java (original)
>>+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/container/BeanManagerImpl.java Wed Sep 10 18:45:38 2014
>>@@ -1223,7 +1223,7 @@ public class BeanManagerImpl implements
>>
>>     public void addAdditionalAnnotatedType(Object extension, AnnotatedType<?> annotatedType)
>>     {
>>-        addAdditionalAnnotatedType(extension, annotatedType, extension + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>>+        addAdditionalAnnotatedType(extension, annotatedType, extension.toString() + annotatedType + AnnotatedElementFactory.OWB_DEFAULT_KEY);
>>     }
>>
>>     public <T> void addAdditionalAnnotatedType(Object extension, AnnotatedType<T> inAnnotatedType, String id)
>>
>>
>>
>>
>>