Mailing-List: contact commits-help@openwebbeans.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openwebbeans.apache.org
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.de;
  h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type;
  b=n2T5SWeHRKPnchl2d6ODi0jGy/3/YYFPLTC1pN9NVegoqoOUXOL9fHYEUS9p7Hwh7unlsSExNjHipRsSX/pqNQRKUInG2tVl04MWLMf1FN6fFtUAovb1/EKHCYbXiu/8HXgkB7Og2OwN0sLNoed3XmMdqp3pa0LSGi2jL76lsb8=;
References: <20140207195832.92BA223889CB@eris.apache.org>
Message-ID: <1391805545.8702.YahooMailNeo@web28901.mail.ir2.yahoo.com>
Date: Fri, 7 Feb 2014 20:39:05 +0000 (GMT)
From: Mark Struberg <struberg@yahoo.de>
Reply-To: Mark Struberg <struberg@yahoo.de>
Subject: Re: svn commit: r1565779 -
 /openwebbeans/branches/owb_1.2.x/webbeans-impl/src/main/java/org/apache/webbeans/proxy/NormalScopeProxyFactory.java
To: "dev@openwebbeans.apache.org" <dev@openwebbeans.apache.org>,
  "commits@openwebbeans.apache.org" <commits@openwebbeans.apache.org>
In-Reply-To: <20140207195832.92BA223889CB@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="542325855-79130063-1391805545=:8702"

--542325855-79130063-1391805545=:8702
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

-1 for this commit, this will most probably break all EAR or other ClassLoa=
der hierarchy scenarios.=0Aplease revert!=0A=0AThe reason for taking the be=
an classloader is that this is the only classloader which guarantees perfec=
t visibility.=0Awhat if we have to create a bean in a shared EAR lib folder=
? If we would use the TCCL, then the created proxy class would get register=
ed in a random WebAppClassLoader, right? And this would cause NoClassDefFou=
nd if the @ApplicationScoped contextual instance would get accessed from an=
other webapp. =0ADo you agree on this?=0A=0AWe've had a long discussion on =
this already...=0AOSGi is in general broken in regards to classloading. I s=
ee no reason why we should break sane scenarios for it.=0A=0ALieGrue,=0Astr=
ub=0A=0A=0A=0A=0A=0AOn Friday, 7 February 2014, 20:58, "rmannibucau@apache.=
org" <rmannibucau@apache.org> wrote:=0A =0AAuthor: rmannibucau=0A>Date: Fri=
 Feb=A0 7 19:58:32 2014=0A>New Revision: 1565779=0A>=0A>URL: http://svn.apa=
che.org/r1565779=0A>Log:=0A>OWB-931 using tccl first in normal scope proxy =
factory - to port to trunk when validated against tomee=0A>=0A>Modified:=0A=
>=A0 =A0 openwebbeans/branches/owb_1.2.x/webbeans-impl/src/main/java/org/ap=
ache/webbeans/proxy/NormalScopeProxyFactory.java=0A>=0A>Modified: openwebbe=
ans/branches/owb_1.2.x/webbeans-impl/src/main/java/org/apache/webbeans/prox=
y/NormalScopeProxyFactory.java=0A>URL: http://svn.apache.org/viewvc/openweb=
beans/branches/owb_1.2.x/webbeans-impl/src/main/java/org/apache/webbeans/pr=
oxy/NormalScopeProxyFactory.java?rev=3D1565779&r1=3D1565778&r2=3D1565779&vi=
ew=3Ddiff=0A>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=0A>--- openwebbeans/branches/owb_1.2.x/webbeans-im=
pl/src/main/java/org/apache/webbeans/proxy/NormalScopeProxyFactory.java (or=
iginal)=0A>+++ openwebbeans/branches/owb_1.2.x/webbeans-impl/src/main/java/=
org/apache/webbeans/proxy/NormalScopeProxyFactory.java Fri Feb=A0 7 19:58:3=
2 2014=0A>@@ -115,18 +115,17 @@ public class NormalScopeProxyFactory ext=0A=
>=0A>=A0 =A0  public <T> T createNormalScopeProxy(Bean<T> bean)=0A>=A0 =A0 =
 {=0A>-=A0 =A0 =A0 =A0 final ClassLoader classLoader;=0A>-=A0 =A0 =A0 =A0 i=
f (bean.getBeanClass() !=3D null)=0A>+=A0 =A0 =A0 =A0 ClassLoader classLoad=
er =3D WebBeansUtil.getCurrentClassLoader();=0A>+=A0 =A0 =A0 =A0 if (classL=
oader =3D=3D null)=0A>=A0 =A0 =A0 =A0  {=0A>-=A0 =A0 =A0 =A0 =A0 =A0 classL=
oader =3D bean.getBeanClass().getClassLoader();=0A>-=A0 =A0 =A0 =A0 }=0A>-=
=A0 =A0 =A0 =A0 else if (OwbBean.class.isInstance(bean) && OwbBean.class.ca=
st(bean).getReturnType() !=3D null)=0A>-=A0 =A0 =A0 =A0 {=0A>-=A0 =A0 =A0 =
=A0 =A0 =A0 classLoader =3D OwbBean.class.cast(bean).getReturnType().getCla=
ssLoader();=0A>-=A0 =A0 =A0 =A0 }=0A>-=A0 =A0 =A0 =A0 else=0A>-=A0 =A0 =A0 =
=A0 {=0A>-=A0 =A0 =A0 =A0 =A0 =A0 classLoader =3D WebBeansUtil.getCurrentCl=
assLoader();=0A>+=A0 =A0 =A0 =A0 =A0 =A0 if (bean.getBeanClass() !=3D null)=
=0A>+=A0 =A0 =A0 =A0 =A0 =A0 {=0A>+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 classLoa=
der =3D bean.getBeanClass().getClassLoader();=0A>+=A0 =A0 =A0 =A0 =A0 =A0 }=
=0A>+=A0 =A0 =A0 =A0 =A0 =A0 else if (OwbBean.class.isInstance(bean) && Owb=
Bean.class.cast(bean).getReturnType() !=3D null)=0A>+=A0 =A0 =A0 =A0 =A0 =
=A0 {=0A>+=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 classLoader =3D OwbBean.class.cas=
t(bean).getReturnType().getClassLoader();=0A>+=A0 =A0 =A0 =A0 =A0 =A0 }=0A>=
=A0 =A0 =A0 =A0  }=0A>=0A>=A0 =A0 =A0 =A0  Class<T> classToProxy;=0A>=0A>=
=0A>=0A>=0A>
--542325855-79130063-1391805545=:8702--