openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: git revision missing when building 4.1.7 from the source tarball
Date Thu, 03 Oct 2019 17:16:03 GMT
Done in 27a447d8e738b70f74ab05606693d7139127efc4

> On Sep 19, 2019, at 8:25 AM, Matthias Seidel <matthias.seidel@hamburg.de> wrote:
> 
> Hi Jim,
> 
> Am 19.09.19 um 13:47 schrieb Jim Jagielski:
>>> On Sep 18, 2019, at 1:43 AM, Don Lewis <truckman@apache.org> wrote:
>>> 
>>> If you build 4.1.7 starting with the source tarball, the git revision
>>> isn't included in the build result because the source tarball doesn't
>>> include the .git directory.  That is needed so that 'git log' can find
>>> the most recent commit hash.  I wasn't able to find a reasonable subset
>>> of the .git contents that would allow this to work.
>>> 
>>> This problem was probably also present with svn, but nobody noticed.
>> It was actually. That is because the RCversion is determined at build time. We could,
when we make the src distribution store that info away in a file someplace, but that would
involve changing the build process (and SvnRevision.pm) accordingly.
>> 
>> Maybe something for 4.2.x and trunk?
> 
> +1
> 
> Matthias
> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>> 
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message