openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kay Schenk <ksch...@apache.org>
Subject Re: Fwd: Re: Questions about buildbot internals
Date Sun, 28 Aug 2016 18:10:09 GMT


On 08/28/2016 10:52 AM, Don Lewis wrote:
> On 28 Aug, Kay Schenk wrote:
>>
>>
>> On 08/27/2016 06:22 PM, Gav wrote:
>>> Hi.
>>>
>>> On Sun, Aug 28, 2016 at 11:01 AM, Don Lewis <truckman@apache.org> wrote:
>>>
>>>> On 28 Aug, Gav wrote:
>>>>> On Sun, Aug 28, 2016 at 10:47 AM, Don Lewis <truckman@apache.org>
wrote:
>>>>>
>>>>>> On 28 Aug, Gav wrote:
>>>>>>> Hi Don,
>>>>>>>
>>>>>>> On Sun, Aug 28, 2016 at 10:31 AM, Don Lewis <truckman@apache.org>
>>>> wrote:
>>>>>>>
>>>>>>>> On 28 Aug, Gav wrote:
>>>>>>>>> junit 4.11 is installed on the new buildbots we are prepping
for
>>>> use
>>>>>> fwiw
>>>>>>>>
>>>>>>>> We'll also need hamcrest version 1.3.
>>>>>>>>
>>>>>>>
>>>>>>> Ubuntu 14.04 LTS python-hamcrest is version 1.8 , is that too
new?
>>>>>>> I'd like to try and stick to what the Ubuntu apt-get packages
provide,
>>>>>>> if not possible, alternate uris where we can get other versions
from.
>>>>>>
>>>>>> We don't want python-hamcrest.  We just want the hamcrest1.3.jar
file.
>>>>>> I think this is it:
>>>>>> <http://repo1.maven.org/maven2/org/hamcrest/hamcrest-
>>>>>> all/1.3/hamcrest-all-1.3.jar>
>>>>>>
>>>>>>
>>>>> ok, in that case should we just not add it as a buildbot buildstep to
>>>>> download it during a build ?
>>>>
>>>> That was something that Damjan suggested as a possibility, but the
>>>> question was whether ext_sources was an appropriate place to stash it as
>>>> it is a compiled artifact.
>>>>
>>>> Based on this old bug report:
>>>> <https://bugs.launchpad.net/ubuntu/+source/junit/+bug/784631>, you
might
>>>> want to investigate whether the junit package actually include hamcrest
>>>> as well.
>>>>
>>>>
>>> I expanded the install /usr/share/java/junit4.jar and saw no evidence of
>>> hamcrest - and
>>> the bug you reference is still open, so not fixed I guess :/
>>>
>>> I found where it is being actively developed (junit4 and junit5) on GitHub.
>>>
>>> https://github.com/junit-team/junit4/blob/master/pom.xml
>>>
>>>  Shows that it pulls in hamcrest as a dependency - does that mean it makes
>>> it available
>>> for use ? I don't know.
>>
>> First of all, thank you for all this work, Gav!
>>
>> If you've got information on the complete pack for Junit4 (4.11), can
>> you see if ANY hamcrest jar is included? I personally just manually
>> downloaded hamcrest-core-1.3.jar, put into /usr/share/java and made a
>> sym link called just  hamcrest.jar to it.
> 
> I don't have a Ubuntu 14 VM handy, but I just got my Ubuntu 16 VM
> working again.  Junit doesn't install hamcrest, and python-hamcrest
> doesn't either.  The package that does install hamcrest-all.jar is
> libhamcrest-java.
> 

Thanks for checking on all this, Don, and you are absolutely correct!
Gav, it seems what we should install  on the new 14.04 systems is this:

http://packages.ubuntu.com/trusty/libhamcrest1.2-java

This should work with the default junit 4.11. We do not want or need the
hamcrest-python.

Unless something's changed significantly in the junit tests (and I have
not researched this), this should work for us. We used junit 4.11 for
testing on AOO 4.1.1.


-- 
----------------------------------------
Kay Schenk
Apache OpenOffice

"Things work out best for those who make
 the best of the way things work out."
                         -- John Wooden

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message