openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Don Lewis <truck...@apache.org>
Subject Re: updated curl patch
Date Sun, 24 Jul 2016 21:50:53 GMT
On 24 Jul, Dennis E. Hamilton wrote:
> 
> 
>> -----Original Message-----
>> From: Don Lewis [mailto:truckman@apache.org]
>> Sent: Sunday, July 24, 2016 12:24
>> To: dev@openoffice.apache.org
>> Subject: updated curl patch
>> 
>> I've updated my curl patch here:
>> <https://bz.apache.org/ooo/show_bug.cgi?id=126896>
>> 
>> I've build tested it on FreeBSD 10, 64-bit CentOS 7, 64-bit Ubuntu 12,
>> and Windows 7.  I've run tested it on CentOS and Windows by doing a
>> File->Open and specifying a ftp:// URL.  I did the same with the
>> FreeBSD port, which uses the same curl version via
>> --with-system-curl.
>> 
>> One of the Linux platforms, Ubuntu as I recall, had problems trying
>> to download the source because of certificate validation issues
>> (hopefully that is fixed with the java download changes).  I noticed
>> that the curl 7.19.7 tarball is checked into svn under ext_sources. 
>> Should I delete that and check in the new source tarball?  What is
>> the criteria for checking stuff in under ext_sources?
> [orcmid] 
> 
> That is an interesting question.  I have the feeling that the
> ext_sources folder is obsolete.
> 
> ANALYSIS
> 
> Looking at ext_sources on trunk, this folder is mainly populated by
> files dated prior to 2012-12-23, none of which were later than the
> first Apache OpenOffice non-incubating release, the AOO 3.4.1 refresh.
>  The only subsequent additions consist of four files added *since*
> release 4.1.2.
> 
> I don't understand the relationship between these and Apache Extras. 
> And that these are binaries on the SVN trunk.

Yes, that seems to be suboptimal.
 
> Furthermore, the ext_sources folder does *not* appear in the source
> release, apache-openoffice-4.1.2-r1709696-src.

True ... anyboody building from a release source tarball is totally
reliant on bootstrap to download all of the extra sources.

> PS: The ext_libraries folder has not been touched since 2014-07-07. 
> It is included in -src.

Yes, some of the bundled software is built over their rather than under
main.  I've never attempted to figure out the logic.

> PPS: Thank you for pointing out, in an earlier post, that you do all
> FreeBSD builds while disconnected from the Internet and don't rely on
> the bootstrap to download anything and that you have what may be a
> more efficient approach that perhaps all of us should use when doing
> release-candidate build-confirmation compiles.

Bootstrap doesn't have much, if anything, to do when building the
FreeBSD port.  All of the necessary external source tarballs have
already been stashed in ext_sources/, and both dmake and epm have
already been built and installed.  The sources come from a giant tarball
that I've previously built and hosted on the FreeBSD infrastructure.
There aren't that many because of the heavy use of --with-system-foo by
the FreeBSD port.

In the general case, the necessary set of sources depends on the flags
passed to configure, and bootstrap looks at the the knobs set by
configure to figure out what to download. If the set of sources was more
dynamic, then the FreeBSD port Makefile would have to duplicate some of
the logic that resides in configure and bootstrap since networking is
turned off before configure is run.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message