openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patricia Shanahan <p...@acm.org>
Subject Re: Profile.c bugs (was RE: Some thoughts on the learning curve)
Date Wed, 02 Mar 2016 18:24:53 GMT
Dennis,

The build output from my Windows build contains the line:

Compiling: sal/osl/w32/profile.cxx

There appear to be three different implementations of the profile 
module, profile.c for "os2", profile.c for "unx", and profile.cxx for 
"w32". Only the "unx" version has pthread_mutex operations, including 
our null point de-reference.

Patricia@Jan2014Desktop /cygdrive/c/OpenOfficeDev/Trunk/main/sal/osl
$ grep -c pthread_mutex */profile.c */profile.cxx
os2/profile.c:0
unx/profile.c:33
w32/profile.cxx:0

All three are significantly different. I think I should next try to 
understand the difference in thread operations between them.

I'll look at SVN logs to see if there is any informative history. Is 
there any write-up I should be reading on how threading is managed on 
the different systems?

Patricia


On 2/29/2016 11:02 AM, Dennis E. Hamilton wrote:
> Patricia,
>
> Take a look at main/sal/inc/osl/profile.h
>
> Methinks that the code identified in <https://bz.apache.org/ooo/show_bug.cgi?id=126669>
might not be built for current releases on Windows or Linux.  You'll see that there are filename
suffixes such as .rc and .ini used.  I doubt that has anything to do with handling profiles
now.
>
> Is there a way we can check that the code is not built and/or and these profile functions
are not used?
>
> I don't know about builds for OS/2 and other downstream builds that we don't make ourselves.
>
> And if the code is really obsolete, we should prune it from trunk and source releases.
>
>   - Dennis
>
>> -----Original Message-----
>> From: Patricia Shanahan [mailto:pats@acm.org]
>> Sent: Saturday, February 20, 2016 20:57
>> To: dev@openoffice.apache.org
>> Subject: Re: Some thoughts on the learning curve
>>
>>
>>
>> On 2/20/2016 8:39 PM, Dennis E. Hamilton wrote:
>>> I sympathize with Pedro's observation.
>>>
>>> Meanwhile, although I am not an expert, I could stand to buddy up on
>>> the following profile-related situation:
>>> <https://bz.apache.org/ooo/show_bug.cgi?id=126669>.
>>
>> Looks interesting. I am familiar with pthread and memory management
>> issues, so it may be a good area for me to work on.
>>
>> Patricia
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message