openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject review requested: [Issue 118023] Calc: Cut-and-paste between spreadsheets causes incorrect cell reference changes : [Attachment 85284] Hack: skip reference updates for inter-document clipboard paste
Date Sun, 14 Feb 2016 14:10:14 GMT
damjan@apache.org has asked  for review:
Issue 118023: Calc:  Cut-and-paste  between spreadsheets causes incorrect cell
reference changes
https://bz.apache.org/ooo/show_bug.cgi?id=118023

Attachment 85284: Hack: skip reference updates for inter-document clipboard
paste
https://bz.apache.org/ooo/attachment.cgi?id=85284&action=edit



--- Comment #6 from damjan@apache.org ---
Created attachment 85284
  --> https://bz.apache.org/ooo/attachment.cgi?id=85284&action=edit
Hack: skip reference updates for inter-document clipboard paste

This hack fixes the bug for me. By not performing reference updates when it's
an inter-document paste (the "pCBFCP->pClipDoc->GetClipParam().getSourceDocID()
== GetDocumentID()" is false), the reference stays correct instead of
referencing the pasted cell. However I am not sure how reference updates work
in general - the ScDocument::UpdateReference() function seems to do a lot,
affecting chart references, area links, validation lists, etc. - so I am not
sure what else could break...

Can somebody more familiar with Calc's internals please weigh in on whether
this approach is right?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message