openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject review denied: [Issue 126635] Possible null pointer dereference : [Attachment 85136] patch to main/sw/source/core/doc/poolfmt.cxx
Date Tue, 17 Nov 2015 13:49:25 GMT has denied  review:
Issue 126635: Possible null pointer dereference

Attachment 85136: patch to main/sw/source/core/doc/poolfmt.cxx

--- Comment #6 from ---
Comment on attachment 85136
patch to main/sw/source/core/doc/poolfmt.cxx

thank you for the patch
but I wouldn't approve the current patch
1. use spaces instead of tabs
2. the new return path when pColl is NULL breaks functionality
3. as you noted in comment 2, lcl_SetNumBul is a helper of
SwDoc::GetTextCollFromPool and the null check should be there if anywhere

@AppChecker review requests in bugzilla get automatic send to dev-list this has
nothing to do with the issue status
it's done to highlight patches and faster review process

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message