openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject review denied: [Issue 126635] Possible null pointer dereference : [Attachment 85136] patch to main/sw/source/core/doc/poolfmt.cxx
Date Tue, 17 Nov 2015 13:49:25 GMT
j.nitschke@ok.de has denied  review:
Issue 126635: Possible null pointer dereference
https://bz.apache.org/ooo/show_bug.cgi?id=126635

Attachment 85136: patch to main/sw/source/core/doc/poolfmt.cxx
https://bz.apache.org/ooo/attachment.cgi?id=85136&action=edit



--- Comment #6 from j.nitschke@ok.de ---
Comment on attachment 85136
  --> https://bz.apache.org/ooo/attachment.cgi?id=85136
patch to main/sw/source/core/doc/poolfmt.cxx

thank you for the patch
but I wouldn't approve the current patch
1. use spaces instead of tabs
https://wiki.openoffice.org/wiki/Cpp_Coding_Standards/FORMAT
https://wiki.openoffice.org/wiki/Cpp_Coding_Standards/FORMAT/NoTabs
2. the new return path when pColl is NULL breaks functionality
3. as you noted in comment 2, lcl_SetNumBul is a helper of
SwDoc::GetTextCollFromPool and the null check should be there if anywhere

@AppChecker review requests in bugzilla get automatic send to dev-list this has
nothing to do with the issue status
it's done to highlight patches and faster review process

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Mime
View raw message