Return-Path: X-Original-To: apmail-openoffice-dev-archive@www.apache.org Delivered-To: apmail-openoffice-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 307261755D for ; Thu, 18 Jun 2015 18:19:17 +0000 (UTC) Received: (qmail 32658 invoked by uid 500); 18 Jun 2015 18:19:17 -0000 Delivered-To: apmail-openoffice-dev-archive@openoffice.apache.org Received: (qmail 32567 invoked by uid 500); 18 Jun 2015 18:19:16 -0000 Mailing-List: contact dev-help@openoffice.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openoffice.apache.org Delivered-To: mailing list dev@openoffice.apache.org Received: (qmail 32555 invoked by uid 99); 18 Jun 2015 18:19:16 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2015 18:19:16 +0000 Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 599CE1A0046 for ; Thu, 18 Jun 2015 18:19:16 +0000 (UTC) Received: by wicnd19 with SMTP id nd19so30651143wic.1 for ; Thu, 18 Jun 2015 11:19:15 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.188.97 with SMTP id fz1mr45197266wic.29.1434651555078; Thu, 18 Jun 2015 11:19:15 -0700 (PDT) Received: by 10.28.6.131 with HTTP; Thu, 18 Jun 2015 11:19:15 -0700 (PDT) In-Reply-To: <558301BA.80200@t-online.de> References: <4B0A990E-F1FA-4202-A5C8-7B595E2422CD@apache.org> <554B0EE2.5090503@gmail.com> <5575AD8D.6090700@t-online.de> <557FC1CC.70904@gmail.com> <558301BA.80200@t-online.de> Date: Thu, 18 Jun 2015 20:19:15 +0200 Message-ID: Subject: Re: [RAT REPORT] - 30 files with an unknown or no License Header From: jan i To: dev@openoffice.apache.org Content-Type: multipart/alternative; boundary=001a11c38dc0512b7e0518ced8ba --001a11c38dc0512b7e0518ced8ba Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for applying the patch. I will check the next RAT-Scan to see if the files sill appear. rgds jan I. On 18 June 2015 at 19:36, Regina Henschel wrote: > Hi Jan, > > jan i schrieb: > >> HI. >> >> did anybody note the rat-scan output, seems we have 6 files still that a= re >> a problem (a probably should be deleted): >> >> Unapproved Licenses: >> >> /home/buildslave19/slave19/openofficeorg-nightly-rat/build/main/ooxml/so= urce/framework/JavaOOXMLParser/.settings/org.eclipse.jdt.core.prefs >> >> /home/buildslave19/slave19/openofficeorg-nightly-rat/build/main/ooxml/so= urce/framework/JavaPartManager/.classpath >> >> /home/buildslave19/slave19/openofficeorg-nightly-rat/build/main/ooxml/so= urce/framework/JavaPartManager/.project >> >> /home/buildslave19/slave19/openofficeorg-nightly-rat/build/main/ooxml/so= urce/framework/JavaPartManager/.settings/org.eclipse.jdt.core.prefs >> >> /home/buildslave19/slave19/openofficeorg-nightly-rat/build/main/ooxml/so= urce/framework/OOXMLViewer/.classpath >> >> /home/buildslave19/slave19/openofficeorg-nightly-rat/build/main/ooxml/so= urce/framework/OOXMLViewer/.project >> > > I had submitted the patch from Gavin McDonald. But that patch contains th= e > lines > Index: main/ooxml/source/framework/JavaPartManager/.classpath > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Cannot display: file marked as a binary type. > svn:mime-type =3D application/xml > Index: main/ooxml/source/framework/JavaPartManager/.project > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Cannot display: file marked as a binary type. > svn:mime-type =3D application/xml > > and > Index: main/ooxml/source/framework/OOXMLViewer/.classpath > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Cannot display: file marked as a binary type. > svn:mime-type =3D application/xml > Index: main/ooxml/source/framework/OOXMLViewer/.project > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Cannot display: file marked as a binary type. > svn:mime-type =3D application/xml > > so for those no change exists in the patch. I read that, but did not > notice the consequence. > > The files > > main/ooxml/source/framework/OOXMLViewer/.settings/org.eclipse.jdt.core.pr= efs > +main/ooxml/source/framework/SchemaParser/.settings/org.eclipse.jdt.core.= prefs > > should have entries in rat-excludes, at least I see that in the commit > message of r1684976. > > Kind regards > Regina > > > >> rgds >> jan i. >> >> >> On 16 June 2015 at 08:27, J=C3=BCrgen Schmidt wr= ote: >> >> On 11/06/15 18:23, jan i wrote: >>> >>>> On 8 June 2015 at 16:58, Regina Henschel >>>> >>> wrote: >>> >>>> >>>> Hi J=C3=BCrgen, >>>>> >>>>> is it OK to commit the patch? >>>>> >>>>> if it not ok to commit the patch, then I wonder how the files was >>>> >>> committed >>> >>>> in the first place. >>>> >>>> If it is not ok, then the files should be deleted. We cannot have file= s >>>> >>> in >>> >>>> trunk without the proper >>>> ALv2 license. >>>> >>>> Furthermore we cannot make a release with these files. >>>> >>>> I recommend applying the patch. Deleting the files might have >>>> >>> sideeffects. >>> >>>> >>>> >>> No it have no sideeffect and yes it is ok to apply the patch. As I >>> explained before these files are part of the started but currently >>> stopped new OOXML framework. It's part of the parser generator ... >>> >>> Anyway it is a eclipse project in Java and the license headers were >>> simply forgotten in the first shot. If you want a Java tooling that >>> would have created C++ stubs and parser for doing the ground work for >>> OOXML parsing ... >>> >>> Again these files should not be part of y source release and can be >>> filtered out as some other things as well. >>> >>> Applying the patch and adding the license header is even better and mor= e >>> clean for future purpose. >>> >>> Juergen >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org >>> For additional commands, e-mail: dev-help@openoffice.apache.org >>> >>> >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org > For additional commands, e-mail: dev-help@openoffice.apache.org > > --001a11c38dc0512b7e0518ced8ba--