openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject review requested: [Bug 122822] Correct viewing of XY-, Column- and Line-Charts limited to 10000 records + 1 Heading row : [Attachment 81359] Fix patch
Date Tue, 20 Aug 2013 09:06:15 GMT
Clarence GUO <> has asked  for review:
Bug 122822: Correct viewing of XY-, Column- and Line-Charts limited to 10000
records + 1 Heading row

Attachment 81359: Fix patch

------- Additional Comments from Clarence GUO <>
The root cause of this defect is in fix of 121058, only some points were picked
up in order to save loading time and memory for tens of thousands of data
points. All data points were divided into many small groups and only picked min
and max points from one group. The reason why only picked min and max points
instead of using a regular distance is, for example, if there is a column or a
line chart, most of data points are around max value 100 and min value 10, only
if we pick max and min values from one group, the chart can keep it's original
outline. But if we use a regular distance, we might only get some mid-value(for
example 50) of the chart and will miss the chart outline.
But the mechanism never consider scatter chart or bubble chart which have
multiple data sequence in one series. For example, for scatter chart, one
series has two sequence, x values and y values. A x value and a y value must be
a pair. Then when pick x values, a min and a max values were picked. When pick
y values, another min and max values were picked. However, the picked min and
max x values probably are not in one pair of min and max y values. For example,
index of min and max x values are 10 and 40. It should get No. 10 and No. 40
values from y values, but it might get No. 30 and No. 35. So in this case, the
chart data are totally corrupt. That is the root cause.
My fix will roll back code of 121058 in ScChart2DataSequence::getNumericalData
and add new fix code in ScChart2DataSequence::BuildDataCache(), then wrong axes
data label issue mentioned by Regina Henschel can be fixed. And new code will
use regular distance to pick up points then problem for scatter chart and other
charts which have multiple sequences in one series can be fixed. If the
distance is small enough, fore-mentioned chart outline issue is no problem. So
I use 5 as regular distance.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message