openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From janI <j...@apache.org>
Subject Re: Build breaker and clean build
Date Thu, 11 Apr 2013 17:30:28 GMT
On Apr 11, 2013 6:43 PM, "Andrew Rist" <andrew.rist@oracle.com> wrote:
>
>
> On 4/11/2013 12:06 AM, Andre Fischer wrote:
>>
>> On 10.04.2013 18:57, Andrew Rist wrote:
>>>
>>>
>>> On 4/10/2013 1:33 AM, Herbert Dürr wrote:
>>>>
>>>> On 2013/04/10 10:09 AM, Andre Fischer wrote:
>>>>>
>>>>> tonight we had a build breaker in the windows build: a slot id that is
>>>>> used in SW had been removed in SVX.  The reference in SW had also been
>>>>> removed, so this change should not be a problem.
>>>>> But the windows build is still not a full build.  Therefore the old SW
>>>>> slot header files where used and the build broke.
>>>>>
>>>>> There is an easy fix for situations like this: a clean build.
>>>>
>>>>
>>>> Incremental build are known to have problems thats why I suggested [1]
to default to a clean build. That didn't receive consensus though and
indeed there are good reasons against it:
>>>>
>>>> The incremental build both tests the dependency system and it reduces
the load when building significantly.
>>>>
>>>> On the already strained buildbot this means a factor of almost five
improvement as clean build takes about 4.5h whereas an incremental build
takes only 0.5-1.0h.
>>>>
>>>> Andrew even had to reschedule the snapshot build away from the weekly
clean build because the buildbot load is a real problem.
>>>>
>>>> [1] http://markmail.org/message/wmlhc5f5zaiiyu2o
>>>> [2] http://markmail.org/message/7q64ijlwygdqmwf3
>>>>
>>> Just to add here, that there are also issues with a clean build. The
clean build fails with some frequency on hung jobs and requires manual
attention.
>>
>>
>> That is one more reason to have more frequent clean builds so that we
can find the cause of these problems.  They are not restricted to the build
bot.   Others are affected, too.  I would have tried to fix this, but I am
not able to reproduce this problem on my local machine.
>
>
> Sorry, I think I was unclear there.  Due to the complexity of our build
process and the interaction with the buildbot, there is a reasonably high
incidence of false positive failures on clean builds.  The Windows build
ends up with hung processes and throws an exception.  If we were to switch
to clean builds we could expect several false positives a week, which would
require manual intervention.  We have tests of clean builds daily on the
linux boxes, so in terms of coverage of the entire AOO buildbot setup, we
have full builds covered.   I see the fact that some of our builds are
incremental and some are clean, as a feature, not as a shortcoming.
>
>
>>
>>> In reality, breaking changes that require a clean build are pretty
rare.  For me, the clean build on the weekend and incremental during the
week seems to be a good compromise.
>>
>>
>> I am not sure about that.   Besides, it is sometimes a bit difficult to
judge 'how incompatible' a change really is.  Change a slot definition in
SVX and its use in SW.  Do we need anything more? With a clean build we are
on the safe side.
>
> It's a trade off.  How many false positives to you get, and how much
manual intervention does the system require.   What I'm trying to
communicate is that my experience with 'this buildbot setup' suggests that
the current approach requires less of my time to keep healthy, and produces
less false positives.
>
>>
>> Besides, the clean-build-on-weekend policy would require us to hold all
incompatible changes until Friday, or live with a broken build during the
week.
>> I really thing that we need a better solution.  A switch for marking a
change as incompatible and that would be interpreted by the build bot would
be the absolute minimum.  But even that would call for trouble.  At Sun we
have been there and it did not really work so well.
>
> This doesn't require waiting until the weekend, it requires a manual
clean run which can be kicked off easily.  (I'm happy to show you, or hit
up Herbert - he has access, too)   I don't disagree with your general
argument, I just see different trade-offs, and I consider this type failure
to have a fairly trivial recovery (kicking off a manual clean build).
just my little 2cent, andrew you are (in my opinion) the one who really
have hands on with our build system (apologize to everyone else who has
hands on, but I  see andrew daily on #asftest).

Can you please state your recommendation clearly, and you have my support.

rgds
jan I
>
> Andrew
>
>>
>>>
>>>>> This may become important in the coming weeks when we have to fix some
>>>>> bugs in the sidebar (which is about to be merged back into trunk).
 The
>>>>> sidebar is implemented in several modules.  Without a clean windows
>>>>> build we will run into build breakers very regularly.
>>>>
>>>>
>>>> It is possible to force a clean build manually.
>>>
>>> I'm cleaning it up now and kicking off a build.
>>
>>
>> Thanks for taking care of this one.
>>
>> -Andre
>>
>>> Andrew
>>>
>>>
>>>>
>>>> Herbert
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>>>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message