Return-Path: 
 <dev-return-30191-apmail-openoffice-dev-archive=openoffice.apache.org@openoffice.apache.org>
X-Original-To: apmail-openoffice-dev-archive@www.apache.org
Delivered-To: apmail-openoffice-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 368DDEFF6
	for <apmail-openoffice-dev-archive@www.apache.org>;
 Thu,  6 Dec 2012 16:37:17 +0000 (UTC)
Received: (qmail 14908 invoked by uid 500); 6 Dec 2012 16:35:20 -0000
Delivered-To: apmail-openoffice-dev-archive@openoffice.apache.org
Received: (qmail 14322 invoked by uid 500); 6 Dec 2012 16:35:16 -0000
Mailing-List: contact dev-help@openoffice.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@openoffice.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@openoffice.apache.org>
List-Post: <mailto:dev@openoffice.apache.org>
List-Id: <dev.openoffice.apache.org>
Reply-To: dev@openoffice.apache.org
Delivered-To: mailing list dev@openoffice.apache.org
Received: (qmail 10353 invoked by uid 99); 6 Dec 2012 16:32:12 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Dec 2012 16:32:12 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: local policy)
Received: from [79.98.78.37] (HELO janik.cz) (79.98.78.37)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Dec 2012 16:32:04 +0000
Received: from [10.0.0.100] (unknown [10.0.0.100])
	by janik.cz (Server) with ESMTP id 4883234E2F2;
	Thu,  6 Dec 2012 17:35:27 +0100 (CET)
Subject: Re: DOCX: merged comments
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=iso-8859-1
From: =?iso-8859-1?Q?Pavel_Jan=EDk?= <Pavel@Janik.cz>
In-Reply-To: <EE3868DE-0D18-4767-8174-8BDE6C35108F@Janik.cz>
Date: Thu, 6 Dec 2012 17:31:43 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <0C7E77A6-1EED-41E6-B4B6-8400367DD1FB@Janik.cz>
References: <C2A077C5-F068-468C-9236-2508AB8B58C9@janik.cz>
 <CANQgRabJ+ty6VpJkjeRDtwNTuWW_WTynNgV1o9EA0tb7+GDAHQ@mail.gmail.com>
 <EE3868DE-0D18-4767-8174-8BDE6C35108F@Janik.cz>
To: dev@openoffice.apache.org
X-Mailer: Apple Mail (2.1085)
X-Virus-Checked: Checked by ClamAV on apache.org


On Nov 30, 2012, at 9:22 AM, Pavel Jan=EDk wrote:

> So yes, the patch is influenced by similar LO change and Apache =
OpenOffice project has to receive original author's ack. Accorging to =
LibreOffice' VCS, it is Cedric. I'll ask him for acknowledgement.

Cedric declined, so if anyone is interested to recreate the change from =
scratch, go for it. It is very simple one. I won't do it myself to =
prevent legal issues.

The problem is very simple:

Grab some DOCX document containing more than two comments (so you can =
check the results). Unzip it.

Investigate Comments part (see Office Open XML Part 1 - Fundamentals And =
Markup Language Reference.pdf for more details).

Investigate=20

xmllint --format word/comments.xml

Grep for comments:

bash-3.2$ xmllint --format word/comments.xml | grep "<w:comment"

Comments are numbered:

  <w:comment w:id=3D"0" w:author=3D"Deborah" =
w:date=3D"2010-11-19T16:41:00Z" w:initials=3D"D">
  <w:comment w:id=3D"1" w:author=3D"Deborah" =
w:date=3D"2010-11-19T14:41:00Z" w:initials=3D"D">
  <w:comment w:id=3D"2" w:author=3D"Deborah" =
w:date=3D"2010-11-19T14:43:00Z" w:initials=3D"D">
  <w:comment w:id=3D"3" w:author=3D"Deborah" =
w:date=3D"2010-11-19T14:49:00Z" w:initials=3D"D">
  <w:comment w:id=3D"4" w:author=3D"Deborah" =
w:date=3D"2010-11-19T14:53:00Z" w:initials=3D"D">
  <w:comment w:id=3D"5" w:author=3D"Deborah" =
w:date=3D"2010-11-19T14:51:00Z" w:initials=3D"D">

According to wml.xsd, attribute id (w:id) is:

  <xsd:complexType name=3D"CT_Markup">
    <xsd:attribute name=3D"id" type=3D"ST_DecimalNumber" =
use=3D"required"/>
  </xsd:complexType>

but our model (writerfilter/source/ooxml/model.xml) contains:

        <attribute name=3D"id">
          <text/>

which means it is being worked on as a string which is wrong. It should =
be ST_DecimalNumber.

And thats all.
--=20
Pavel Jan=EDk