Return-Path: X-Original-To: apmail-openoffice-dev-archive@www.apache.org Delivered-To: apmail-openoffice-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D144DF80 for ; Fri, 30 Nov 2012 11:05:04 +0000 (UTC) Received: (qmail 54853 invoked by uid 500); 30 Nov 2012 11:05:03 -0000 Delivered-To: apmail-openoffice-dev-archive@openoffice.apache.org Received: (qmail 54782 invoked by uid 500); 30 Nov 2012 11:05:03 -0000 Mailing-List: contact dev-help@openoffice.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openoffice.apache.org Delivered-To: mailing list dev@openoffice.apache.org Received: (qmail 54761 invoked by uid 99); 30 Nov 2012 11:05:03 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2012 11:05:03 +0000 Received: from localhost (HELO mail-bk0-f46.google.com) (127.0.0.1) (smtp-auth username chengjh, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2012 11:05:02 +0000 Received: by mail-bk0-f46.google.com with SMTP id q16so146016bkw.33 for ; Fri, 30 Nov 2012 03:04:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.153.15 with SMTP id i15mr241897bkw.64.1354273499679; Fri, 30 Nov 2012 03:04:59 -0800 (PST) Received: by 10.205.74.136 with HTTP; Fri, 30 Nov 2012 03:04:59 -0800 (PST) In-Reply-To: References: Date: Fri, 30 Nov 2012 19:04:59 +0800 Message-ID: Subject: Re: WaE: sw/source/filter/ww8 compiler warnings From: chengjh To: dev@openoffice.apache.org Content-Type: multipart/alternative; boundary=0015175cd5cee08aaf04cfb45eb0 --0015175cd5cee08aaf04cfb45eb0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable I will have a look..... On Fri, Nov 30, 2012 at 3:54 AM, Pavel Jan=EDk wrote: > Hi, > > current trunk issues few warnings in sw/source/filter/ww8: > > cc1plus: warnings being treated as errors > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8par3.cx= x: > In member function =91SwNumRule* WW8ListManager::GetNumRule(int)=92: > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8par3.cx= x:1125: > warning: comparison between signed and unsigned integer expressions > make: *** [/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/350/ > unxmacxi.pro/workdir/CxxObject/sw/source/filter/ww8/ww8par3.o] Error 1 > > cc1plus: warnings being treated as errors > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx= : > In member function =91void WW8_WrtBookmarks::MoveFieldMarks(sal_uLong, > sal_uLong)=92: > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx= :317: > warning: comparison between signed and unsigned integer expressions > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx= : > In member function =91int WW8Export::CollectGrfsOfBullets() const=92: > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx= :1452: > warning: comparison between signed and unsigned integer expressions > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx= : > In member function =91int WW8Export::GetGrfIndex(const SvxBrushItem&)=92: > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/wrtww8.cxx= :1535: > warning: comparison between signed and unsigned integer expressions > make: *** [/Users/pavel/BUILD/BuildDir/ooo_trunk_src/solver/350/ > unxmacxi.pro/workdir/CxxObject/sw/source/filter/ww8/wrtww8.o] Error 1 > > The following patch "fixes" these issues, but I'd like to see author > committing the change: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- wrtww8.cxx (revision 1415339) > +++ wrtww8.cxx (working copy) > @@ -314,7 +314,7 @@ > { > if (aItr->second) > { > - if (aItr->second->first =3D=3D nFrom) > + if (aItr->second->first =3D=3D static_cast(nFrom)) > { > aItr->second->second.first =3D true; > aItr->second->first =3D nTo; > @@ -1449,7 +1449,7 @@ > if ( pGrf ) > { > bool bHas =3D false; > - for (int i =3D 0; i < > m_vecBulletPic.size(); ++i) > + for (unsigned int i =3D 0; i < > m_vecBulletPic.size(); ++i) > { > if > (m_vecBulletPic[i]->GetChecksum() =3D=3D pGrf->GetChecksum()) > { > @@ -1532,7 +1532,7 @@ > int nIndex =3D -1; > if ( rBrush.GetGraphic() ) > { > - for (int i =3D 0; i < m_vecBulletPic.size(); ++i) > + for (unsigned int i =3D 0; i < m_vecBulletPic.size(); ++i= ) > { > if (m_vecBulletPic[i]->GetChecksum() =3D=3D > rBrush.GetGraphic()->GetChecksum()) > { > Index: ww8par3.cxx > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- ww8par3.cxx (revision 1415339) > +++ ww8par3.cxx (working copy) > @@ -1122,7 +1122,7 @@ > > SwNumRule* WW8ListManager::GetNumRule(int i) > { > - if ( i >=3D 0 && i < maLSTInfos.size() ) > + if ( i >=3D 0 && static_cast(i) < maLSTInfos.size() ) > return maLSTInfos[i]->pNumRule; > else > return 0; > > > -- > Pavel Jan=EDk > > > > --=20 Best Regards,Jianhong Cheng --0015175cd5cee08aaf04cfb45eb0--