openoffice-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chengjh <chen...@apache.org>
Subject Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format
Date Wed, 28 Nov 2012 06:03:52 GMT
Committed with 1414498.thanks for the code review.


On Thu, Nov 22, 2012 at 11:27 AM, chengjh <chengjh@apache.org> wrote:

> Thanks to Fan's effort.
>
>
> On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng <zheng.easyfan@gmail.com>wrote:
>
>> I will take a look at the patch. thx.
>>
>>
>>
>> 2012/11/21 Joost Andrae <Joost.Andrae@gmx.de>
>>
>> > Hi,
>> >
>> > maybe it helps if someone documents the usage of issue ids within the
>> > source code for unexperienced developers.
>> >
>> > In this example the issue represented by i120928 ( := OOo Issue Tracker
>> ID
>> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
>> > show_bug.cgi?id=120928<
>> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
>> >
>> > Am 21.11.2012 08:20, schrieb chengjh:
>> >
>> >  Updated the patch according to the comments...Please review
>> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> >> action=diff.Thanks<
>> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
>> >> .
>> >>
>> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hdu@apache.org> wrote:
>> >>
>> >>  I agree with Pedro that the change history belongs into the RCS,
>> >>> especially in a code base as ours where some source files have had
>> many
>> >>> hundreds of changes over their history of about twenty years.
>> >>>
>> >>> Of course an issue reference is valuable when the comment helps to
>> >>> understand what the code does and why it does it. Anything else is
>> >>> distracting.
>> >>>
>> >>
>> > Kind regards, Joost
>> >
>> >
>> >
>>
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
>


-- 

Best Regards,Jianhong Cheng

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message