opennlp-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joern Kottmann (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENNLP-402) CLI tools and formats refactored
Date Thu, 01 Dec 2011 19:42:41 GMT

    [ https://issues.apache.org/jira/browse/OPENNLP-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161077#comment-13161077
] 

Joern Kottmann commented on OPENNLP-402:
----------------------------------------

To clarify the class renaming statement, we cannot rename classes which are part of our public
API. All classes which are located inside the cmdline package are not public API.
So we can replaces interfaces with abstract classes, rename things, etc.

What do you think about my proposed CmdLineTool as the top class? AbstractCLITool could be
a util class and everything could be imported via static imports.

I suggest that we commit now what is there and we then do additional changes to the AbstractXXX
classes in a new patch.
                
> CLI tools and formats refactored
> --------------------------------
>
>                 Key: OPENNLP-402
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-402
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Command Line Interface, Formats
>    Affects Versions: tools-1.5.3-incubating
>            Reporter: Aliaksandr Autayeu
>              Labels: patch
>         Attachments: 0016-CLI-tools-and-formats-refactored.patch, 0017-added-direct-format-support-to-CLI-tools-and-formats.patch,
open-nlp-cli-package.png
>
>
> Proposed patch refactors CLI tools and simplifies the code by introducing hierarchy and
removing a lot of code duplication. It also introduces better error and help messages, including
help for formats and listing available formats in various tools, which are now able to work
with formats directly. This, in turn, eliminates the need to keep converted files on disk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message