Return-Path: 
 <opennlp-issues-return-680-apmail-incubator-opennlp-issues-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-opennlp-issues-archive@minotaur.apache.org
Delivered-To: apmail-incubator-opennlp-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E8A508947
	for <apmail-incubator-opennlp-issues-archive@minotaur.apache.org>;
 Thu, 18 Aug 2011 15:12:51 +0000 (UTC)
Received: (qmail 48681 invoked by uid 500); 18 Aug 2011 15:12:51 -0000
Delivered-To: apmail-incubator-opennlp-issues-archive@incubator.apache.org
Received: (qmail 48656 invoked by uid 500); 18 Aug 2011 15:12:51 -0000
Mailing-List: contact opennlp-issues-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:opennlp-issues-help@incubator.apache.org>
List-Unsubscribe: <mailto:opennlp-issues-unsubscribe@incubator.apache.org>
List-Post: <mailto:opennlp-issues@incubator.apache.org>
List-Id: <opennlp-issues.incubator.apache.org>
Reply-To: opennlp-issues@incubator.apache.org
Delivered-To: mailing list opennlp-issues@incubator.apache.org
Received: (qmail 48645 invoked by uid 99); 18 Aug 2011 15:12:51 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2011 15:12:51 +0000
X-ASF-Spam-Status: No, hits=-2001.1 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2011 15:12:48 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 376DBC25C5
	for <opennlp-issues@incubator.apache.org>;
 Thu, 18 Aug 2011 15:12:27 +0000 (UTC)
Date: Thu, 18 Aug 2011 15:12:27 +0000 (UTC)
From: "William Colen (JIRA)" <jira@apache.org>
To: opennlp-issues@incubator.apache.org
Message-ID: 
 <1421731833.49331.1313680347221.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1838778430.13890.1310658060042.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OPENNLP-226) Evaluators should allow tools to
 register a misclassified report interface
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/OPENNLP-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087050#comment-13087050 ] 

William Colen commented on OPENNLP-226:
---------------------------------------

The revision #1159270 modified the listeners. Now it is more general.

- renamed the listener to EvaluationSampleListener and add two new methods. The method list would be:

  void correctlyClassified(T reference, T prediction);
  void missclassified(T reference, T prediction);

- The EvaluationErrorPrinter now is abstract and implements the EvaluationSampleListener, adding a default implementation for correctlyClassified. The missclassified should be implemented by the subclass, like ChunkEvaluationErrorListener.

The abstract class Evaluator will now has the following new methods:

  void notifyCorrectlyClassified(T reference, T prediction);
  void notifyMissclassified(T reference, T prediction);
  void addListener(EvaluationSampleListener<T> listener);
  void removeListener(EvaluationSampleListener<T> listener);
  T processSample

The method processSample should be implemented by subclasses. In the future it will be made abstract. The default implementation of evaluateSample calls the notifyCorrectlyClassified and notifyMissclassified according to the result of processSample.

> Evaluators should allow tools to register a misclassified report interface
> --------------------------------------------------------------------------
>
>                 Key: OPENNLP-226
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-226
>             Project: OpenNLP
>          Issue Type: New Feature
>          Components: Chunker, Command Line Interface, Name Finder, POS Tagger, Sentence Detector, Tokenizer
>    Affects Versions: tools-1.5.2-incubating
>            Reporter: William Colen
>            Assignee: William Colen
>            Priority: Minor
>             Fix For: tools-1.5.2-incubating
>
>
> OPENNLP-220 introduced the -misclassified argument that enables evaluators to print misclassified items while using the command line evaluators. We should expand it to allow any other tool that uses evaluators to register an interface to get that information.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira