Mailing-List: contact dev-help@opennlp.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@opennlp.apache.org
Received-SPF: pass (nike.apache.org: domain of agerri.rodrigo@gmail.com
 designates 74.125.82.43 as permitted sender)
Date: Thu, 8 May 2014 10:39:20 +0200
From: Rodrigo Agerri <agerri.rodrigo@gmail.com>
To: dev@opennlp.apache.org
Subject: Re: TokenNameFinder and Span probs
Message-ID: <20140508083920.GA4323@U102733.bp.ehu.es>
References: 
 <CAPgc0t4DaqPnQ1Vr4ku+v+N1RPiM=UbgXaDu1zQLthpSLNj_NA@mail.gmail.com>
 <CA+V=Wqj3AxeUF0=EJYK-MTpE3OvkUycZq3G-gusYi-5-4dD6OA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+V=Wqj3AxeUF0=EJYK-MTpE3OvkUycZq3G-gusYi-5-4dD6OA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

+1 to the second solution too, and to use this solution everywhere where a Span
object is returned. 

Rodrigo

On 2014/05/07 at 09:22, Joern Kottmann wrote:
> Hello Mark,
> 
> +1 for your second solution. I believe that is much more intuitive than
> calling a method afterwards to retrieve the prob for a Span.
> it is easier to use because the prob is delivered as part of the result and
> no user action is required to obtain it.
> 
> We could use this solution everywhere where a span gets returned.
> 
> J�rn
> 
> 
> 
> On Wed, May 7, 2014 at 2:18 AM, Mark G <giaconiamark@gmail.com> wrote:
> 
> > I am currently working on a project in which we are using NER to to pass
> > toponyms into the GeoEntityLinker addon for geotagging and I am passing on
> > the locations, entities, and other info into SOLR for indexing. Over the
> > years I have noticed that the TokenNameFinder interface does not include
> > all the probs() methods that the NameFinderME has, and furthermore the Span
> > object does not have a double field for storing a prob for itself.  Also
> > the sentenceDetector has a method called getSentenceProbabilities rather
> > than probs().
> > When I pass the Spans into the GeoEntityLinker/EntityLinker I can't get the
> > probs anymore because they are not in the Span objects. I can always extend
> > Span and add the field, or keep a 2D array of the probs for each sentence,
> > but wanted to see what everyone thinks about
> > 1. adding the probs methods to the TokenNameFinder interface
> > 2. adding a prob field to Span (a double)
> > 3. Having the NameFinder return the prob with each Span so it doesn't have
> > to be set after the call to find() using the double[] of probs
> > 4. Have the sentencedetectorME return its spans with a prob, add probs()
> > method to the SentenceDetector interface, and deprecate the
> > getSentenceProbabilities...
> >
> > Thoughts?
> >