opennlp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörn Kottmann <kottm...@gmail.com>
Subject Re: svn commit: r1564379 [1/2] - in /opennlp/trunk/opennlp-tools/src: main/java/opennlp/tools/cmdline/ main/java/opennlp/tools/cmdline/chunker/ main/java/opennlp/tools/cmdline/doccat/ main/java/opennlp/tools/cmdline/namefind/ main/java/opennlp/tools/cmdlin...
Date Thu, 06 Feb 2014 12:32:00 GMT
On 02/06/2014 01:28 PM, Jörn Kottmann wrote:
> On 02/04/2014 06:10 PM, markg@apache.org wrote:
>> Modified: 
>> opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerTool.java
>> URL:http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerTool.java?rev=1564379&r1=1564378&r2=1564379&view=diff

>>
>> ============================================================================== 
>>
>> --- 
>> opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerTool.java

>> (original)
>> +++ 
>> opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerTool.java

>> Tue Feb  4 17:10:11 2014
>> @@ -14,7 +14,6 @@
>>    * See the License for the specific language governing permissions and
>>    * limitations under the License.
>>    */
>
> <SNIP>
>>   -      ObjectStream<String> lineStream =
>> -        new PlainTextByLineStream(new InputStreamReader(System.in));
>> -
>> -      PerformanceMonitor perfMon = new 
>> PerformanceMonitor(System.err, "sent");
>> -      perfMon.start();
>> +      ObjectStream<String> lineStream = null;
>> +      PerformanceMonitor perfMon = null;
>>           try {
>> +        lineStream = new PlainTextByLineStream(new 
>> MockInputStreamFactory(System.in), "UTF-8");
>> +        perfMon = new PerformanceMonitor(System.err, "sent");
>> +        perfMon.start();
>
>
> What is the motivation to move the start of the performance monitoring 
> down? Before it measured opening
> the input stream as well, now it won't.
>
> If you think it should not include opening the stream I suggest we do 
> this change in a separate jira issue and handle it
> identical in all places.


Ups, my mistake, I was looking at the wrong file. Here it was moved down 
to maintain the order.
But in the TokenNameFinderTool it was changed.

Jörn

Mime
View raw message