Return-Path: X-Original-To: apmail-incubator-opennlp-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-opennlp-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C01EBCC0 for ; Sun, 22 Jan 2012 18:24:53 +0000 (UTC) Received: (qmail 70024 invoked by uid 500); 22 Jan 2012 18:24:53 -0000 Delivered-To: apmail-incubator-opennlp-dev-archive@incubator.apache.org Received: (qmail 69948 invoked by uid 500); 22 Jan 2012 18:24:52 -0000 Mailing-List: contact opennlp-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: opennlp-dev@incubator.apache.org Delivered-To: mailing list opennlp-dev@incubator.apache.org Received: (qmail 69939 invoked by uid 99); 22 Jan 2012 18:24:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2012 18:24:52 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of william.colen@gmail.com designates 209.85.161.175 as permitted sender) Received: from [209.85.161.175] (HELO mail-gx0-f175.google.com) (209.85.161.175) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2012 18:24:46 +0000 Received: by ggnp4 with SMTP id p4so835880ggn.6 for ; Sun, 22 Jan 2012 10:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=dVxIAPd1ZfkIwqaWqCeOn98svxX7yOzkknA6BOcsIWM=; b=SrfttUuTK7/QW7d7XHC9L7JLTwekcwqW1bqcYLcXrw5lm6JfeIdTvmfpE8zFfltpxs ezcatIeAg1Vk8KQfJ5GPziHdQn5HhPa8TnNmpYAvheCaubx0V+2XhWn6KhIYh6jXe1GM QCs1iAJKBu+fM302JK6kqRWmvLYl3bRySgg84= Received: by 10.236.128.232 with SMTP id f68mr7607801yhi.17.1327256666221; Sun, 22 Jan 2012 10:24:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.162.15 with HTTP; Sun, 22 Jan 2012 10:24:05 -0800 (PST) In-Reply-To: References: <4F160CB2.6030900@gmail.com> <4F16920E.1040302@gmail.com> From: "william.colen@gmail.com" Date: Sun, 22 Jan 2012 16:24:05 -0200 Message-ID: Subject: Re: Error in POS Tagger CrossValidator To: opennlp-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thank you, Aliaksandr, I really like how we can use stream factories during training and evaluating tools. The changes you did are great. I don't know if we need to improve the documentation. The code looks good. Now I understand it better with your commit to fix this issue. Thanks William On Sun, Jan 22, 2012 at 8:56 AM, Aliaksandr Autayeu wrote: > Hi William! > > Thank you for pointing this out. I have fixed it. Can you check and close > the issue? > > How can I improve the documentation (or the code itself) so that the new > code is easier to understand? Any advice? > > Aliaksandr > > On Thu, Jan 19, 2012 at 2:57 PM, william.colen@gmail.com < > william.colen@gmail.com> wrote: > >> Aliaksandr, >> >> Could you also check the issue >> https://issues.apache.org/jira/browse/OPENNLP-418 ? I tried to fix it >> by myself but I could not find an appropriate solution. I still have >> to better understand the new code. >> >> Thank you, >> William >> >> >> On Wed, Jan 18, 2012 at 7:34 AM, J=F6rn Kottmann wr= ote: >> > On 1/18/12 1:05 AM, James Kosin wrote: >> >> >> >> I put the TODO there; because I couldn't determine if it was a better >> >> place. =A0The only big downside to using the Stream is we have no con= trol >> >> over the encoding. =A0So, I was thinking more that this method of loa= ding >> >> the item would be deprecated anyway. =A0In favor of the other method. >> > >> > >> > Decoding with the correct encoding is the responsibility of the >> > Reader. There is no need to pass an encoding along in this method, rig= ht? >> > >> > J=F6rn >>