Return-Path: 
 <opennlp-dev-return-1644-apmail-incubator-opennlp-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-opennlp-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-opennlp-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7AC41741D
	for <apmail-incubator-opennlp-dev-archive@minotaur.apache.org>;
 Mon,  5 Dec 2011 21:23:18 +0000 (UTC)
Received: (qmail 66169 invoked by uid 500); 5 Dec 2011 21:23:18 -0000
Delivered-To: apmail-incubator-opennlp-dev-archive@incubator.apache.org
Received: (qmail 66131 invoked by uid 500); 5 Dec 2011 21:23:18 -0000
Mailing-List: contact opennlp-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:opennlp-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:opennlp-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:opennlp-dev@incubator.apache.org>
List-Id: <opennlp-dev.incubator.apache.org>
Reply-To: opennlp-dev@incubator.apache.org
Delivered-To: mailing list opennlp-dev@incubator.apache.org
Received: (qmail 66121 invoked by uid 99); 5 Dec 2011 21:23:18 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2011 21:23:18 +0000
X-ASF-Spam-Status: No, hits=1.5 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of aliaksandr@autayeu.com
 designates 74.125.83.47 as permitted sender)
Received: from [74.125.83.47] (HELO mail-ee0-f47.google.com) (74.125.83.47)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2011 21:23:11 +0000
Received: by eeav2 with SMTP id v2so549790eea.6
        for <multiple recipients>; Mon, 05 Dec 2011 13:22:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=autayeu.com; s=google;
        h=mime-version:x-originating-ip:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type;
        bh=trHrmQNSQG/wfH1xPxl5YyLvmKIuWgMSol1SSYUaIK8=;
        b=VzuHLMr4FS5hotPEsZl3USQesBnleVgBR1uTFp0U9Y8BPxX2xbtEiV4wZvGRRb9kvD
         USMQa7srja25wK5Q/tXsYyBO1RP7djC4xyxUs6SdyMiowH0o0HuZFoAxe54fW9UutqjO
         ntJwPrx6U9Yp6vWUdT2vQ8aRw34F9S6VItdNE=
MIME-Version: 1.0
Received: by 10.213.20.79 with SMTP id e15mr1422620ebb.149.1323120170327; Mon,
 05 Dec 2011 13:22:50 -0800 (PST)
Received: by 10.204.164.144 with HTTP; Mon, 5 Dec 2011 13:22:50 -0800 (PST)
X-Originating-IP: [2.156.230.14]
In-Reply-To: <4EDC3EFD.6030901@gmail.com>
References: <2489550.32308.1322771440038.JavaMail.tomcat@hel.zones.apache.org>
	<4EDC3EFD.6030901@gmail.com>
Date: Mon, 5 Dec 2011 22:22:50 +0100
Message-ID: 
 <CAGWxipS6NmNN-HpBCBB5nHexH4c_ALj-amgzOJ9OEkqZUf59BA@mail.gmail.com>
Subject: Re: [jira] [Commented] (OPENNLP-402) CLI tools and formats refactored
From: Aliaksandr Autayeu <aliaksandr@autayeu.com>
To: opennlp-dev@incubator.apache.org
Cc: opennlp-issues@incubator.apache.org
Content-Type: multipart/alternative; boundary=0015174c0e8ebf5e9004b35eebd8
X-Virus-Checked: Checked by ClamAV on apache.org

--0015174c0e8ebf5e9004b35eebd8
Content-Type: text/plain; charset=UTF-8

The refactoring moved language parameters into factories - it can be better
used there, for example for filtering some multilingual datasets, or to
allow language-specific things. So it became a part of data format
parameters in stream factories. In some cases it is necessary, it others it
might not be. It is always needed for training. It might be needed for some
datasets for evaluation as well. Since the formats now work uniformly, in
some cases it became necessary, because the same factory produces a stream
for testing and for training and thus requires the language
parameter. Factories are not aware of the way the stream will be used.
Please, advise if you know a better solution.

Aliaksandr

On Mon, Dec 5, 2011 at 4:48 AM, James Kosin <james.kosin@gmail.com> wrote:

> Hmm....
> Any reason why the evaluator needs a -lang parameter as being mandatory
> now?
>
> James
>
> On 12/1/2011 3:30 PM, Aliaksandr Autayeu (Commented) (JIRA) wrote:
> >     [
> https://issues.apache.org/jira/browse/OPENNLP-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161118#comment-13161118]
> >
> > Aliaksandr Autayeu commented on OPENNLP-402:
> > --------------------------------------------
> >
> > OK, I'll make another proposal for the class hierarchy in CLI package,
> taking into account current discussion. I'll see other tickets as well.
> >
> >> CLI tools and formats refactored
> >> --------------------------------
> >>
> >>                 Key: OPENNLP-402
> >>                 URL: https://issues.apache.org/jira/browse/OPENNLP-402
> >>             Project: OpenNLP
> >>          Issue Type: Improvement
> >>          Components: Command Line Interface, Formats
> >>    Affects Versions: tools-1.5.3-incubating
> >>            Reporter: Aliaksandr Autayeu
> >>            Assignee: Aliaksandr Autayeu
> >>              Labels: patch
> >>         Attachments: 0016-CLI-tools-and-formats-refactored.patch,
> 0017-added-direct-format-support-to-CLI-tools-and-formats.patch,
> open-nlp-cli-package.png
> >>
> >>
> >> Proposed patch refactors CLI tools and simplifies the code by
> introducing hierarchy and removing a lot of code duplication. It also
> introduces better error and help messages, including help for formats and
> listing available formats in various tools, which are now able to work with
> formats directly. This, in turn, eliminates the need to keep converted
> files on disk.
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
> >
>
>

--0015174c0e8ebf5e9004b35eebd8--