opennlp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Kosin <james.ko...@gmail.com>
Subject Re: svn commit: r1174486 - /incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/util/Span.java
Date Sat, 24 Sep 2011 02:07:28 GMT
On 9/23/2011 4:15 AM, Jörn Kottmann wrote:
> On 9/23/11 3:36 AM, jkosin@apache.org wrote:
>> Modified:
>> incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/util/Span.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/util/Span.java?rev=1174486&r1=1174485&r2=1174486&view=diff
>> ==============================================================================
>>
>> ---
>> incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/util/Span.java
>> (original)
>> +++
>> incubator/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/util/Span.java
>> Fri Sep 23 01:36:19 2011
>> @@ -119,7 +119,7 @@ public class Span implements Comparable<
>>     }
>>
>>     public boolean contains(int index) {
>> -    return start<= index&&  index<= end;
>> +    return start<= index&&  index<  end;
>>     }
>>
>>     /**
>>
>>
>
> Is there code in Span which calls this method?
>
> Jörn
Jorn,

The DictionaryFeatureGenerator seems to be the only one that directly
uses the InSanGenerator; which uses the Span class.

Beyond that, I don't know the effects.  I ran with the namefinder data I
have and all checks out against the runs before the change.  Could you
test on the models and or test the ones that directly relate to these
feature generators?  Please.

Thanks,
James

Mime
View raw message