opennlp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "william.colen@gmail.com" <william.co...@gmail.com>
Subject Re: svn commit: r1159447 - in /incubator/opennlp/trunk/opennlp-tools/src: main/java/opennlp/tools/chunker/ main/java/opennlp/tools/cmdline/chunker/ main/java/opennlp/tools/cmdline/namefind/ main/java/opennlp/tools/cmdline/postag/ main/java/opennlp/to
Date Sat, 20 Aug 2011 05:13:59 GMT
On Fri, Aug 19, 2011 at 7:55 AM, Jörn Kottmann <kottmann@gmail.com> wrote:

> On 8/19/11 12:38 PM, william.colen@gmail.com wrote:
>
>> >  I still believe that the case where you just have one
>>> >  EvaluationSampleListener object that
>>> >  should be hooked up is the most frequent use case, and its very rare
>>> that
>>> >  people want to
>>> >  hookup multiple.
>>> >
>>> >  To make that easy, I suggest that we add a constructor which just
>>> takes one
>>> >  listener.
>>> >
>>>
>> Should we do it to all XYEvaluators or only with the Evaluator class? It
>> is
>> a lot of new constructors!
>>
>
> Maybe we can do it only in the XYEvaluators, and make it call the one with
> the list,
> we can use the Collections util to create the list, like you did in one of
> your tests.
>
> The old constructor should also call the List constructor, to avoid code
> duplication.
>
> I can help out here, if you want.
>
> Jörn
>

Thank you, Jörn. I will work on that tomorrow (Saturday).

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message