opennlp-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörn Kottmann <kottm...@gmail.com>
Subject Re: svn commit: r1159447 - in /incubator/opennlp/trunk/opennlp-tools/src: main/java/opennlp/tools/chunker/ main/java/opennlp/tools/cmdline/chunker/ main/java/opennlp/tools/cmdline/namefind/ main/java/opennlp/tools/cmdline/postag/ main/java/opennlp/to
Date Tue, 23 Aug 2011 13:41:16 GMT
On 8/23/11 3:40 PM, william.colen@gmail.com wrote:
> On Tue, Aug 23, 2011 at 5:31 AM, Jörn Kottmann<kottmann@gmail.com>  wrote:
>
>> On 8/23/11 6:07 AM, william.colen@gmail.com wrote:
>>
>>> I added variable length param only for the Chunker. Please check if it
>>> looks
>>> OK. If yes I will do it for the other tools.
>>>
>> Looks good to me, you don't need the null check for the variable length
>> param. If the user passes null, he gets a NullPointerException.
>>
>> In the case he doesn't pass anything you get an empty array.
>>
>> What do you think, is the variable length param way better than the other?
>>
> Yes, it looks nicer. I will do it for the other tools now.
>
+1

Jörn

Mime
View raw message