openmeetings-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Solodovnik <solomax...@gmail.com>
Subject Re: profile picture url [PATCH]
Date Wed, 06 Feb 2013 08:22:16 GMT
the code is duplicated in several places ....
going to generalize it


On Wed, Feb 6, 2013 at 3:19 PM, Maxim Solodovnik <solomax666@gmail.com>wrote:

> The only issue I see: places other than profile like user list, chat etc.
> I'll double check
>
>
> On Wed, Feb 6, 2013 at 3:18 PM, Maxim Solodovnik <solomax666@gmail.com>wrote:
>
>> I'm already checking and going to commit with my changes ...
>>
>>
>> On Wed, Feb 6, 2013 at 3:16 PM, seba.wagner@gmail.com <
>> seba.wagner@gmail.com> wrote:
>>
>>> Hi Vieri,
>>>
>>> I will check the patch, but it might take a while.
>>> The other issue would be also possible to solve, we do sync for example
>>> I think the password by every login from ldap to our database (if
>>> configured as "sync_password" = true). We would have to do simply the same
>>> for every attribute.
>>> So that everytime the user logs in the LDAP attributes are read from
>>> ldap and synced to OpenMeetings.
>>> Deleting the user is problematic as there might be files associated to
>>> his private drive or private messages/calendar events that would be all
>>> gone if you create a new user with every login.
>>>
>>> Sebastian
>>>
>>>
>>> 2013/2/6 Vieri <rentorbuy@yahoo.com>
>>>
>>>> Hi,
>>>>
>>>> I'm attaching a patch to fix the picture URI in case it's HTTP in the
>>>> dashboard.
>>>> This should fix the first part of my report.
>>>>
>>>> However, the second problem is still there and is probably harder to
>>>> fix (see below - previous email). Basically, once a user has logged in once
>>>> via LDAP and is created in the OM DB, there's no way the picture URL will
>>>> be updated from LDAP again.
>>>> Maybe auto-deleting the LDAP "type" user from the OM DB every time the
>>>> LDAP user signs out (or times out) could be a hack that solves this (but
>>>> sounds ugly).
>>>>
>>>> Vieri
>>>>
>>>> --- On *Tue, 2/5/13, Vieri <rentorbuy@yahoo.com>* wrote:
>>>>
>>>>
>>>>
>>>> There's also another smaller glitch.
>>>> Suppose you login OK with an LDAP/AD user. OM will correctly set the
>>>> 'pictureuri' field in the 'user' table with the URL taken from LDAP/AD.
>>>> However, if I change the user's URL within LDAP/AD and the user logs
>>>> into OM again then he/she will keep seeing the old picture. In fact, the
>>>> 'user.pictureuri' field is NOT updated.
>>>> It's not a big deal but it would be nice to be able to update picture
>>>> URIs in LDAP/AD for OM users who have already logged in at least once via
>>>> LDAP.
>>>>
>>>> Vieri
>>>>
>>>> --- On *Tue, 2/5/13, Maxim Solodovnik <solomax666@gmail.com>* wrote:
>>>>
>>>>
>>>> From: Maxim Solodovnik <solomax666@gmail.com>
>>>> Subject: Re: profile picture url
>>>> To: "user" <user@openmeetings.apache.org>
>>>> Date: Tuesday, February 5, 2013, 5:53 AM
>>>>
>>>> seems like URLs are resolved as local to OM instead of being resolved
>>>> as external ....
>>>> maybe Sebastian can fix it :)
>>>>
>>>>
>>>> On Tue, Feb 5, 2013 at 5:43 PM, Vieri <rentorbuy@yahoo.com> wrote:
>>>>
>>>> Let me correct what I just reported: the log indicates an "error" and
>>>> when I go to the user's dashboard, I don't see the user's picture (I only
>>>> see the OM default picture). However, if I enter the user's profile then
I
>>>> can correctly see the image... So it has been correctly uploaded but it
>>>> only displays when I go to the user's profile page but not in the dashboard.
>>>>
>>>> --- On *Tue, 2/5/13, Vieri <rentorbuy@yahoo.com>* wrote:
>>>>
>>>>
>>>>
>>>> There's a glitch...
>>>>
>>>> As you can see in the log below, the URL is correctly retrieved from my
>>>> LDAP directory but it generates an error (incorrect construct?).
>>>>
>>>> DEBUG 02-05 11:43:25.102 DownloadHandler.java 730760 220
>>>> org.apache.openmeetings.servlet.outputhandler.DownloadHandler
>>>> [http-bio-0.0.0.0-5080-exec-6] - requestedFile: _profile_
>>>> http://mydomain.com/pictures/2064.jpg current_dir:
>>>> /opt/openmeetings/red5/webapps/openmeetings/upload/profiles/profile_2
>>>> DEBUG 02-05 11:43:25.104 DownloadHandler.java 730762 230
>>>> org.apache.openmeetings.servlet.outputhandler.DownloadHandler
>>>> [http-bio-0.0.0.0-5080-exec-6] - LOG DownloadHandler: The request file is
>>>> not readable
>>>> DEBUG 02-05 11:43:25.105 DownloadHandler.java 730763 234
>>>> org.apache.openmeetings.servlet.outputhandler.DownloadHandler
>>>> [http-bio-0.0.0.0-5080-exec-6] - LOG ERROR requestedFile: _profile_
>>>> http://mydomain.com/pictures/2064.jpg
>>>> DEBUG 02-05 11:43:25.106 DownloadHandler.java 730764 238
>>>> org.apache.openmeetings.servlet.outputhandler.DownloadHandler
>>>> [http-bio-0.0.0.0-5080-exec-6] - LOG endsWith d.jpg
>>>> DEBUG 02-05 11:43:25.107 DownloadHandler.java 730765 240
>>>> org.apache.openmeetings.servlet.outputhandler.DownloadHandler
>>>> [http-bio-0.0.0.0-5080-exec-6] - LOG moduleName: userprofile
>>>> DEBUG 02-05 11:43:25.109 DownloadHandler.java 730767 260
>>>> org.apache.openmeetings.servlet.outputhandler.DownloadHandler
>>>> [http-bio-0.0.0.0-5080-exec-6] - full_path:
>>>> /opt/openmeetings/red5/webapps/openmeetings/default/profile_pic.jpg
>>>>
>>>>
>>>> --- On *Tue, 2/5/13, Vieri <rentorbuy@yahoo.com>* wrote:
>>>>
>>>>
>>>> downloading, compiling and testing... will let you know.
>>>> Thanks!
>>>>
>>>> --- On *Tue, 2/5/13, seba.wagner@gmail.com <seba.wagner@gmail.com>*wrote:
>>>>
>>>>
>>>> From: seba.wagner@gmail.com <seba.wagner@gmail.com>
>>>> Subject: Re: profile picture url
>>>> To: user@openmeetings.apache.org
>>>> Date: Tuesday, February 5, 2013, 3:37 AM
>>>>
>>>> you can try with latest SVN, the key would be:ldap_user_picture_uri
>>>> Only an absolute URL makes sense, since the UI will otherwise use the
>>>> string in the picture_uri of the user entity and send a request to an
>>>> OpenMeetings servlet.
>>>> But if the String in picture_uri starts with "http" it should directly
>>>> download and rescale it.
>>>> Make sure your profile pics are are at appropriate sizes (not 2MB each
>>>> one), otherwise the entire app could get slow while downloading the profile
>>>> pic. Something like 24x24pixels mights be good.
>>>>
>>>> Sebastian
>>>>
>>>>
>>>> 2013/2/5 Vieri <rentorbuy@yahoo.com>
>>>>
>>>> I can set the attribute in my LDAP/AD if you want me to test it via svn.
>>>>
>>>>
>>>> --- On *Tue, 2/5/13, seba.wagner@gmail.com <seba.wagner@gmail.com>*wrote:
>>>>
>>>>
>>>> From: seba.wagner@gmail.com <seba.wagner@gmail.com>
>>>> Subject: Re: profile picture url
>>>> To: user@openmeetings.apache.org
>>>> Date: Tuesday, February 5, 2013, 3:21 AM
>>>>
>>>>
>>>> Yes,
>>>>
>>>> I was just looking at that. Indeed there is no key defined for that.
>>>> But that would be the solution that makes the most sense.
>>>> Its probably not that hard, but I can't test it cause I have no LDAP.
>>>> Do you have the attribute already in Ldap?
>>>>
>>>> Sebastian
>>>>
>>>>
>>>> 2013/2/5 Vieri <rentorbuy@yahoo.com<http://mc/compose?to=rentorbuy@yahoo.com>
>>>> >
>>>>
>>>> By the way, the OM LDAP module doesn't allow to specify a picture URI,
>>>> right?
>>>> The ideal scenario would be for me to store the picture URI within the
>>>> LDAP directory and upon LDAP user login, OM would upload the picture URI
>>>> correctly.
>>>>
>>>>
>>>> --- On *Tue, 2/5/13, Maxim Solodovnik <solomax666@gmail.com<http://mc/compose?to=solomax666@gmail.com>
>>>> >* wrote:
>>>>
>>>>
>>>> From: Maxim Solodovnik <solomax666@gmail.com<http://mc/compose?to=solomax666@gmail.com>
>>>> >
>>>> Subject: Re: profile picture url
>>>> To: "user" <user@openmeetings.apache.org<http://mc/compose?to=user@openmeetings.apache.org>
>>>> >
>>>> Date: Tuesday, February 5, 2013, 3:15 AM
>>>>
>>>>
>>>> images can not be just added to the file system :(
>>>> DB should be updated correspondingly
>>>>
>>>>
>>>> On Tue, Feb 5, 2013 at 3:12 PM, Vieri <rentorbuy@yahoo.com<http://mc/compose?to=rentorbuy@yahoo.com>
>>>> > wrote:
>>>>
>>>> Thanks.
>>>> Actually my users log in via LDAP.
>>>> So the user records are cerated in the 'users' tabel as soon as they
>>>> correclty log in for the first time. But the pictureurl is invalid.
>>>> I don't want each user to upload their own pictures (they can do so if
>>>> they wish but I'd like their default picture to be loaded).
>>>>
>>>> So maybe I could use the
>>>> http://openmeetings.apache.org/FileService.html calls to "update" a
>>>> user's profile picture...
>>>>
>>>> --- On *Tue, 2/5/13, seba.wagner@gmail.com<http://mc/compose?to=seba.wagner@gmail.com>
>>>> <seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>>*wrote:
>>>>
>>>>
>>>> From: seba.wagner@gmail.com<http://mc/compose?to=seba.wagner@gmail.com><
>>>> seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>>
>>>> Subject: Re: profile picture url
>>>> To: user@openmeetings.apache.org<http://mc/compose?to=user@openmeetings.apache.org>
>>>> Date: Tuesday, February 5, 2013, 3:08 AM
>>>>
>>>> If you plan to login external users with their own profile pic the best
>>>> way would be to do the via the REST/SOAP API.
>>>> Almost any SOAP/REST call contains the pictureUri as parameter for the
>>>> setUserObjectXYZ... call:
>>>> http://openmeetings.apache.org/UserService.html
>>>>
>>>> There is some simple sample PHP script that does login some random user
>>>> into OpenMeetings (even with a profile pic):
>>>>
>>>> http://svn.apache.org/repos/asf/openmeetings/trunk/plugins/facebook_connect/test.php
>>>>
>>>> Sebastian
>>>>
>>>> Sebastian
>>>>
>>>>
>>>> 2013/2/5 Vieri <rentorbuy@yahoo.com<http://mc/compose?to=rentorbuy@yahoo.com>
>>>> >
>>>>
>>>> Is there a way to do this on the OM server directly without user/client
>>>> intervention?
>>>> I'd like to do a script which takes the OM user ID as input and
>>>> searches its picture in a custom database and uploads/copies it to the OM
>>>> server to the appropriate user profile directory.
>>>> Is there already a way to do this?
>>>>
>>>> thanks,
>>>>
>>>> Vieri
>>>>
>>>> --- On *Tue, 2/5/13, Maxim Solodovnik <solomax666@gmail.com<http://mc/compose?to=solomax666@gmail.com>
>>>> >* wrote:
>>>>
>>>>
>>>> From: Maxim Solodovnik <solomax666@gmail.com<http://mc/compose?to=solomax666@gmail.com>
>>>> >
>>>>
>>>> Subject: Re: profile picture url
>>>> To: "user" <user@openmeetings.apache.org<http://mc/compose?to=user@openmeetings.apache.org>
>>>> >
>>>> Date: Tuesday, February 5, 2013, 2:38 AM
>>>>
>>>>
>>>> you should upload picture by updating user profile (this is the only
>>>> option I know)
>>>>
>>>>
>>>> On Tue, Feb 5, 2013 at 2:35 PM, Vieri <rentorbuy@yahoo.com<http://mc/compose?to=rentorbuy@yahoo.com>
>>>> > wrote:
>>>>
>>>> I'm not sure if the pictureurl field in table 'users' can be set to
>>>> something like http://myserver.com/pictures/user_id.jpeg ?
>>>> I suppose not... I believe the picture must be uploaded to the OM
>>>> server "upload" directory.
>>>> Is that right?
>>>>
>>>> Vieri
>>>>
>>>> --- On *Mon, 2/4/13, seba.wagner@gmail.com<http://mc/compose?to=seba.wagner@gmail.com>
>>>> <seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>>*wrote:
>>>>
>>>>
>>>> From: seba.wagner@gmail.com<http://mc/compose?to=seba.wagner@gmail.com><
>>>> seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>>
>>>> Subject: Re: profile picture url
>>>> To: user@openmeetings.apache.org<http://mc/compose?to=user@openmeetings.apache.org>
>>>> Date: Monday, February 4, 2013, 9:56 PM
>>>>
>>>> yes,
>>>>
>>>> *.psd;*.tiff;*.bmp;*.svg;*.dpx;*.exr;*.jpg;*.jpeg;*.gif;*.png
>>>>
>>>> should all work.
>>>>
>>>> Sebastian
>>>>
>>>>
>>>> 2013/2/5 Vieri <rentorbuy@yahoo.com<http://mc/compose?to=rentorbuy@yahoo.com>
>>>> >
>>>>
>>>> Hi,
>>>>
>>>> Are jpeg pictures allowed/supported for the user profile?
>>>> gif images seem to work but no luck for me with jpeg.
>>>>
>>>> Thanks,
>>>>
>>>> Vieri
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Sebastian Wagner
>>>> https://twitter.com/#!/dead_lock
>>>> http://www.webbase-design.de
>>>> http://www.wagner-sebastian.com
>>>> seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> WBR
>>>> Maxim aka solomax
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Sebastian Wagner
>>>> https://twitter.com/#!/dead_lock
>>>> http://www.webbase-design.de
>>>> http://www.wagner-sebastian.com
>>>> seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> WBR
>>>> Maxim aka solomax
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Sebastian Wagner
>>>> https://twitter.com/#!/dead_lock
>>>> http://www.webbase-design.de
>>>> http://www.wagner-sebastian.com
>>>> seba.wagner@gmail.com <http://mc/compose?to=seba.wagner@gmail.com>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Sebastian Wagner
>>>> https://twitter.com/#!/dead_lock
>>>> http://www.webbase-design.de
>>>> http://www.wagner-sebastian.com
>>>> seba.wagner@gmail.com
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> WBR
>>>> Maxim aka solomax
>>>>
>>>>
>>>
>>>
>>> --
>>> Sebastian Wagner
>>> https://twitter.com/#!/dead_lock
>>> http://www.webbase-design.de
>>> http://www.wagner-sebastian.com
>>> seba.wagner@gmail.com
>>>
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>
>
> --
> WBR
> Maxim aka solomax
>



-- 
WBR
Maxim aka solomax

Mime
View raw message