openmeetings-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Solodovnik <solomax...@gmail.com>
Subject Re: CalendarDialog changes between v4.0.6 branch and master
Date Sat, 27 Oct 2018 12:10:47 GMT
Hmm, just have checked this package
No big differences

Can you create PR for any branch and I'll perform the merge, would it be OK?

Master is actually should work same way as 4.0.x
What are your steps to get this error?

is it reproducible on demo server?

On Sat, 27 Oct 2018 at 19:04, Maxim Solodovnik <solomax666@gmail.com> wrote:

> Hello Ankush,
>
> I can sync both branches for you
> Is `org.apache.openmeetings.web.user.calendar` package will be sufficient?
>
> On Sat, 27 Oct 2018 at 18:10, Ankush Mishra <ankushmishra9@gmail.com>
> wrote:
>
>> Hello Maxim,
>>
>> I was just testing the updated code for the Calendar behaviour, and
>> notice that, there are some discrepancies between the branches *master*
>> and *4.0.x*.
>>
>> From git blame, I notice this arises from this commit here
>> <https://github.com/apache/openmeetings/commit/575638b29ea0ba415be5598741993c32e09b3262#diff-5a3e333589e00fd9afa94b85942e3924>
>> , as an example refer to CalendarDialog changes. Should I thus, base my
>> work off of master or the 4.0.x branch? Currently it's based off of master.
>>
>> Regards
>> Ankush
>>
>
>
> --
> WBR
> Maxim aka solomax
>


-- 
WBR
Maxim aka solomax

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message