openmeetings-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastien <seb...@gmail.com>
Subject Re: possible task for newcomers
Date Wed, 29 Jan 2014 16:40:31 GMT
What a pressure on my little shoulders... :p


On Wed, Jan 29, 2014 at 5:32 PM, Maxim Solodovnik <solomax666@gmail.com>wrote:

> Unfortunately ivy doesn't allow to easily switch to snapshot :(
> I need to enter new URL every day :(
>
> Will retest with plain 6.13 and will wait for release if will not work,
> I'm afraid I have small chances to release before next week anyway :)
>
> Thanks!
>
>
> On Wed, Jan 29, 2014 at 11:23 PM, Sebastien <sebfz1@gmail.com> wrote:
>
>> Hi Maxim,
>>
>> Nice investigation !!
>> I remember a discussion about this resize and the weird behavior... But
>> can it be done automatically (because it seems to be) ?
>> http://arshaw.com/fullcalendar/docs/display/windowResize/
>>
>> Yes I can release 6.13.1, but I would like to upgrade to jQuery UI 1.10.4
>> first (the version you are now using btw)
>> According to the changelog it should not be a big deal, but I should test
>> all the samples anyway. The problem is that I do not have a lot of free
>> time this week... :s
>>
>> Can you deal with a snapshot release for the next coming days? If yes, I
>> can do it tonight with your pull request...
>>
>> Best regards,
>> Sebastien.
>>
>>
>>
>> On Wed, Jan 29, 2014 at 5:05 PM, Maxim Solodovnik <solomax666@gmail.com>wrote:
>>
>>> Hello Sebastien,
>>>
>>> I have found the issue with event resize:
>>> It is my window.resize handler: $(window).resize(function() {
>>> setCalendarHeight(); } );
>>>
>>> Without it calendar is not being resized on window resize
>>> With it event resize is broken :(
>>>
>>> I'll add timer behavior to set Calendar height once in the second ....
>>> this should fix the issue :(
>>>
>>> Can I ask you to release 6.13.1?
>>>
>>>
>>>
>>> On Wed, Jan 29, 2014 at 8:47 PM, Maxim Solodovnik <solomax666@gmail.com>wrote:
>>>
>>>> I guess I have fixed Wysiwyg editor (event resize is still broken, will
>>>> try debug resize)
>>>> I'll prepare the patch and will send it via github
>>>>
>>>>
>>>> On Wed, Jan 29, 2014 at 5:41 PM, Maxim Solodovnik <solomax666@gmail.com
>>>> > wrote:
>>>>
>>>>> Thanks!
>>>>> might works, will try :)
>>>>>
>>>>>
>>>>> On Wed, Jan 29, 2014 at 5:23 PM, Sebastien <sebfz1@gmail.com> wrote:
>>>>>
>>>>>> Yes, I imagine... But maybe could you do the opposite:
>>>>>>
>>>>>> 1/ start with a quickstart and a working calendar
>>>>>> 2/ add jasny-file-upload, see how it behaves
>>>>>> 3/ remove jasny-file-upload, add wysiwyg, see how it behaves
>>>>>> 4/ remove wysiwyg, add bootstrap, see how it behaves
>>>>>>
>>>>>> Then could can isolate the different issues...
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Jan 29, 2014 at 11:16 AM, Maxim Solodovnik <
>>>>>> solomax666@gmail.com> wrote:
>>>>>>
>>>>>>> I guess I need to modify both my code (remove jasny-file-upload
and
>>>>>>> add it partially without full bootstrap) and perform the same
task with
>>>>>>> WYSIWYG editor :(
>>>>>>>
>>>>>>> seems to be lots of work :(
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Jan 29, 2014 at 5:08 PM, Sebastien <sebfz1@gmail.com>
wrote:
>>>>>>>
>>>>>>>> Ok, I see it now.
>>>>>>>> The first thing, IMO, is to know whether or not 'eventResize'
event
>>>>>>>> is fired (fullcalendar.js)... I guess it is not fired but
it is good to be
>>>>>>>> sure...
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Jan 29, 2014 at 4:03 AM, Maxim Solodovnik <
>>>>>>>> solomax666@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Thanks for the NPE, I'll fix it right now :) (without
JIRA)
>>>>>>>>> By Calendar resize issue I mean: events are not being
resized in
>>>>>>>>> weekly view :( some conflicts seems to remain.
>>>>>>>>> Will try to figure out how to handle it
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Jan 29, 2014 at 6:07 AM, Sebastien <sebfz1@gmail.com>wrote:
>>>>>>>>>
>>>>>>>>>> Hi Maxim,
>>>>>>>>>>
>>>>>>>>>> Thanks for the update, I checked out the new code,
compiled and
>>>>>>>>>> run the app.
>>>>>>>>>>
>>>>>>>>>> My short feedback:
>>>>>>>>>> - It is really better ! :)
>>>>>>>>>> - I do not have the calendar event resize issue (I
did not test
>>>>>>>>>> before your commit)
>>>>>>>>>> - I see the emoticon dropdown issue, I will try to
investigate on
>>>>>>>>>> Thursday
>>>>>>>>>> - I've got.... a NPE in
>>>>>>>>>> http://localhost:5080/openmeetings/#profile/messages,
by trying
>>>>>>>>>> to send a mail. I filled the contact and clicked
send. If the message is
>>>>>>>>>> empty, the NPE occurs
>>>>>>>>>> Would you like I open an issue in JIRA?
>>>>>>>>>>
>>>>>>>>>> java.lang.NullPointerException
>>>>>>>>>>      at org.apache.openmeetings.web.user.profile.MessageDialog.onSubmit(MessageDialog.java:196)
>>>>>>>>>>      at com.googlecode.wicket.jquery.ui.widget.dialog.AbstractFormDialog$DialogFormSubmitter.onSubmit(AbstractFormDialog.java:279)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Which corresponds to
>>>>>>>>>> getBean(MailHandler.class).send(to.getAdresses().getEmail(),
>>>>>>>>>> WebSession.getString(1301) + p.getSubject(), *p.getMessage()*.replaceAll("\\<.*?>",
>>>>>>>>>> "") + aLinkHTML);
>>>>>>>>>>
>>>>>>>>>> Best regards,
>>>>>>>>>> Sebastien
>>>>>>>>>>
>>>>>>>>>> On Tue, Jan 28, 2014 at 6:28 PM, Maxim Solodovnik
<
>>>>>>>>>> solomax666@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Seems like rendering bootstrap*.js resources
on the very top
>>>>>>>>>>> partially fixes the issues
>>>>>>>>>>> Unfortunately not all of them :(
>>>>>>>>>>>
>>>>>>>>>>> Calendar event resize and emotion icons drop-down
are still
>>>>>>>>>>> broken :(
>>>>>>>>>>> I'll commit my changes
>>>>>>>>>>> Maybe it will be helpful
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> WBR
>>>>>>>>> Maxim aka solomax
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> WBR
>>>>>>> Maxim aka solomax
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> WBR
>>>>> Maxim aka solomax
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> WBR
>>>> Maxim aka solomax
>>>>
>>>
>>>
>>>
>>> --
>>> WBR
>>> Maxim aka solomax
>>>
>>
>>
>
>
> --
> WBR
> Maxim aka solomax
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message