openmeetings-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Кочура Иван <kiv.i...@gmail.com>
Subject Re: OPENMEETINGS-560
Date Fri, 05 Apr 2013 09:21:54 GMT
Unfortunately, I can not fix the appearance of a second window with an
unknown error. It possible to apply the patch? In HTLM5 version, this error is
missing.


2013/4/4 Кочура Иван <kiv.ivan@gmail.com>

> Hello Irina,
> Thanks for the answer. I will correct.
>
> >>>I see two error message windoes instead of one when I save duplicated
> key record.
> I guess it is related to the task OPENMEETINGS-507<https://issues.apache.org/jira/browse/OPENMEETINGS-507>
>
>
>
>
> 2013/4/4 Maxim Solodovnik <solomax666@gmail.com>
>
>> Additionally there is not optimal copy/pasted code.
>>
>> I'm going to rewrite your patch and will let you know
>> On Apr 4, 2013 1:13 PM, "Irina Arkhipets" <irina.arkhipets@gmail.com>
>> wrote:
>>
>> > Hi Ivan,
>> >
>> > I've reviewed your patch and found some problems with this.
>> >
>> > You can find more detailed explanation in the bug comments.
>> >
>> > Generally, you don't take into account that non-deleted duplicated
>> > records can exist in the database before your patch was applied. No
>> > changes for import/export there.
>> >
>> > Additionally, I see two error message windoes instead of one when I
>> > save duplicated key record.
>> >
>> > Best regards,
>> > Irina.
>> >
>> >
>> >
>> > On Mon, Apr 1, 2013 at 6:14 PM, Кочура Иван <kiv.ivan@gmail.com>
wrote:
>> >
>> > > The patch attached.
>> > >
>> > >
>> > > 2013/3/28 Кочура Иван <kiv.ivan@gmail.com>
>> > >
>> > > >
>> > > > Can I start to implement?
>> > > >
>> > > >
>> > > > 2013/3/25 Кочура Иван <kiv.ivan@gmail.com>
>> > > >
>> > > >> When we remove the key, it is marked as "deleted". Consequently,
>> when
>> > we
>> > > >> add a new key (removed earlier), we need to update the existing
>> > record.
>> > > >>
>> > > >>
>> > > >> 2013/3/25 Maxim Solodovnik <solomax666@gmail.com>
>> > > >>
>> > > >>> It is need to be investigated ....
>> > > >>> Coniguration key should be unique, BUT since we are performing
>> "soft"
>> > > >>> delete this might be a problem: you cannot add same key once
>> deleted
>> > > >>>
>> > > >>>
>> > > >>> On Mon, Mar 25, 2013 at 3:54 PM, Кочура Иван <kiv.ivan@gmail.com>
>> > > wrote:
>> > > >>>
>> > > >>> > Will there be enough to add a unique modifier on the
server? In
>> > this
>> > > >>> case,
>> > > >>> > we get a database error if the client will get hacked.
>> > > >>> >
>> > > >>> >
>> > > >>> > 2013/3/25 Maxim Solodovnik <solomax666@gmail.com>
>> > > >>> >
>> > > >>> > > Actually it should be performed on 2 clients (Flash
+ Wicket)
>> and
>> > > on
>> > > >>> > server
>> > > >>> > > On server it might be done by adding UNIQUE to the
column
>> > > definition
>> > > >>> > > (deletion should be investigated in this case)
>> > > >>> > >
>> > > >>> > >
>> > > >>> > > On Mon, Mar 25, 2013 at 1:37 PM, Кочура Иван
<
>> kiv.ivan@gmail.com
>> > >
>> > > >>> wrote:
>> > > >>> > >
>> > > >>> > > > Hello Maxim.
>> > > >>> > > > I'm going to perform a task
>> > > >>> > > > #560<https://issues.apache.org/jira/browse/OPENMEETINGS-560
>> >
>> > > >>> > > > .
>> > > >>> > > > Checks should be performed only on the client,
or also in
>> the
>> > > >>> > > > ConfigurationDao?
>> > > >>> > > > Do I need to create a new error message? If
so, tell us in a
>> > few
>> > > >>> words
>> > > >>> > > how,
>> > > >>> > > > please.
>> > > >>> > > >
>> > > >>> > >
>> > > >>> > >
>> > > >>> > >
>> > > >>> > > --
>> > > >>> > > WBR
>> > > >>> > > Maxim aka solomax
>> > > >>> > >
>> > > >>> >
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> --
>> > > >>> WBR
>> > > >>> Maxim aka solomax
>> > > >>>
>> > > >>
>> > > >>
>> > > >
>> > >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message