openmeetings-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "seba.wagner@gmail.com" <seba.wag...@gmail.com>
Subject Re: svn commit: r1292789 - /incubator/openmeetings/trunk/singlewebapp/src/app/org/openmeetings/app/persistence/beans/recording/RoomClient.java
Date Thu, 23 Feb 2012 14:02:40 GMT
Hi Maxim,

if you change the getter-method of this value the meaning is different.

See the documentation of "avClient"

/**
	 * If true this client is only used to stream audio/video events,
	 * he should not receive any sync events / push messages <br/>
	 * <br/>
	 * null means not initialized yet<br/>
	 * true the user is an audio/video connection<br/>
	 * false the user is a regular user with full session object<br/>
	 *
	 */
	@Column(name="isAVClient")
	private Boolean isAVClient = null;

with your implementation there is no way of getting the "null".

The problem is that we have 3 rtmpConnection:
1) screensharing
2) audio/video
3) main connection

RoomClient is main connection if rcl.getAvClient() == false and
ircl.isScreenSharing() == false AND rcl.getAvClient() != null

see: ClientListManager.java method:

public synchronized RoomClient getClientByPublicSID(String publicSID,
Boolean isAVClient)

Cause if the avClient is NULL that does mean that he is NOT an avClient.

So this function has to return NULL as long as avClient was not set.

Sebastian


2012/2/23 <solomax@apache.org>

> Author: solomax
> Date: Thu Feb 23 13:14:21 2012
> New Revision: 1292789
>
> URL: http://svn.apache.org/viewvc?rev=1292789&view=rev
> Log:
> NPE while stoping recording is fixed
>
> Modified:
>
>  incubator/openmeetings/trunk/singlewebapp/src/app/org/openmeetings/app/persistence/beans/recording/RoomClient.java
>
> Modified:
> incubator/openmeetings/trunk/singlewebapp/src/app/org/openmeetings/app/persistence/beans/recording/RoomClient.java
> URL:
> http://svn.apache.org/viewvc/incubator/openmeetings/trunk/singlewebapp/src/app/org/openmeetings/app/persistence/beans/recording/RoomClient.java?rev=1292789&r1=1292788&r2=1292789&view=diff
>
> ==============================================================================
> ---
> incubator/openmeetings/trunk/singlewebapp/src/app/org/openmeetings/app/persistence/beans/recording/RoomClient.java
> (original)
> +++
> incubator/openmeetings/trunk/singlewebapp/src/app/org/openmeetings/app/persistence/beans/recording/RoomClient.java
> Thu Feb 23 13:14:21 2012
> @@ -672,7 +672,7 @@ public class RoomClient implements Seria
>         * @return
>         */
>        public Boolean getIsAVClient() {
> -               return isAVClient;
> +               return isAVClient == null ? false : isAVClient;
>        }
>
>        public void setIsAVClient(Boolean isAVClient) {
>
>
>


-- 
Sebastian Wagner
http://www.openmeetings.de
http://incubator.apache.org/openmeetings/
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message