Mailing-List: contact users-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@openjpa.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: <004a01ca3748$d02159a0$70640ce0$@com>
References: <d486f41c0909151114i3652bc69ue7519de0a101fd6e@mail.gmail.com>
	 <001e01ca36fe$431fc8b0$c95f5a10$@com>
	 <d486f41c0909161208o4bb62a27r96abf89f23fb2f2f@mail.gmail.com>
	 <002201ca3704$577235e0$0656a1a0$@com>
	 <d486f41c0909161238y263e6410waa6163d8c0f4c7ac@mail.gmail.com>
	 <002801ca370c$d53fbda0$7fbf38e0$@com>
	 <d486f41c0909161350k63c11183ub88708ca8cd71626@mail.gmail.com>
	 <002d01ca371f$49e6d960$ddb48c20$@com>
	 <d486f41c0909161733o89ebe5dia0ed0f59f1bfba14@mail.gmail.com>
	 <004a01ca3748$d02159a0$70640ce0$@com>
Date: Thu, 17 Sep 2009 09:40:22 -0400
Message-ID: <d486f41c0909170640v6b4013f4q903f9fd9f7550354@mail.gmail.com>
Subject: Re: SingleFieldManager crash
From: Daryl Stultz <daryl@6degrees.com>
To: users@openjpa.apache.org
Content-Type: multipart/alternative; boundary=00151748e8c03ce02c0473c628e9

--00151748e8c03ce02c0473c628e9
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Sep 16, 2009 at 11:41 PM, C N Davies <cnd@cndavies.com> wrote:

> I've put a try catch around my code that is triggering the issue,


I've written the following code to assist my debugging:

private void collectJpaDebug(String name, Object object, StringBuffer sb,
EntityManager em) {
sb.append(name + ": " + object);
try {
if (object != null) {
sb.append("-");
OpenJPAEntityManager emo = (OpenJPAEntityManager) em;
sb.append("EM:");
sb.append(emo.isDetached(object) ? "D" : "d");
sb.append(emo.isDirty(object) ? "X" : "x");
sb.append(emo.isNewlyPersistent(object) ? "N" : "n");
sb.append(emo.isPersistent(object) ? "P" : "p");
sb.append(emo.isRemoved(object) ? "R" : "r");
sb.append(emo.isTransactional(object) ? "T" : "t");
EntityManagerImpl emi = (EntityManagerImpl) em;
final Broker broker = emi.getBroker();
sb.append(" BK:");
sb.append(broker.isDetachedNew() ? "C" : "c");
sb.append(broker.isDirty(object) ? "X" : "x");
sb.append(broker.isNew(object) ? "N" : "n");
sb.append(broker.isPersistent(object) ? "P" : "p");
sb.append(broker.isDeleted(object) ? "R" : "r");
sb.append(broker.isTransactional(object) ? "T" : "t");
OpenJPAStateManager sm = broker.getStateManager(object);
sb.append(" SM:");
if (sm != null) {
sb.append(sm.isDetached() ? "D" : "d");
sb.append(sm.isDirty() ? "X" : "x");
sb.append(sm.isNew() ? "N" : "n");
sb.append(sm.isPersistent() ? "P" : "p");
sb.append(sm.isProvisional() ? "V" : "v");
sb.append(sm.isDeleted() ? "R" : "r");
sb.append(sm.isTransactional() ? "T" : "t");
} else {
sb.append("null");
}
}
} catch (Throwable exc) {
sb.append(exc);
}
sb.append("\n");
}

This generates a number of "flags" for the various properties. So for this
case:

EntityManager em = getEm();
A a = em.find(A.class, 1);
// EM:dxnPrt BK:cxnPrt SM:dxnPvrt
em.close();
em = getEm(); // a different em
// EM:Dxnprt BK:cxnprt SM:null
a = new A();
// EM:dxnprt BK:cxnprt SM:null
a.setId(1);
// EM:dxnprt BK:cxnprt SM:null

I've added the resulting "flags" after the operations. It seems the only
time an object has a state manager is when it is currently managed. Detached
objects have no sm. I guess I had the "feeling" the state manager was part
of the enhanced object, but it looks like it's in the em. So going back to
the code of SingleFieldManager:

   *private* *void* preFlushPC(ValueMetaData vmd, Object obj, *boolean*
 logical,

        OpCallbacks call) {

        *if* (obj == *null*)

            *return*;


        OpenJPAStateManager sm;


        *if* (vmd.getCascadePersist() == ValueMetaData.*CASCADE_NONE*) {

            *if* (!_broker.isDetachedNew() && _broker.isDetached(obj))

                *return*; // allow but ignore


            sm = _broker.getStateManager(obj);

            *if* (sm == *null* || !sm.isPersistent())

                *throw* *new* InvalidStateException(

                    *_loc*.get("cant-cascade-persist", vmd))

                    .setFailedObject(obj);

        } *else* {


I think it's fair to say that it's failing on sm == null rather than
!sm.isPersistent() since the FailedObject is at least detached and possibly
"unmanaged" altogether (whatever that means). Since my debugging always
returns on the blue line, the question is now why, once in a great while,
does it now think that the object is not detached (read: not formerly
managed by a different em). There's also the possiblility that
_broker.isDetachedNew() is wrong - I don't know what that means yet.

-- 
Daryl Stultz
_____________________________________
6 Degrees Software and Consulting, Inc.
http://www.6degrees.com
mailto:daryl@6degrees.com

--00151748e8c03ce02c0473c628e9--