From dev-return-27021-archive-asf-public=cust-asf.ponee.io@openjpa.apache.org Mon Dec 14 13:18:51 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id E7011180634 for ; Mon, 14 Dec 2020 14:18:50 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 33C9A43B87 for ; Mon, 14 Dec 2020 13:18:50 +0000 (UTC) Received: (qmail 61341 invoked by uid 500); 14 Dec 2020 13:18:50 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 61329 invoked by uid 99); 14 Dec 2020 13:18:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2020 13:18:49 +0000 From: =?utf-8?q?GitBox?= To: dev@openjpa.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bopenjpa=5D_struberg_commented_on_pull_request_=234?= =?utf-8?q?2=3A_=5BOPENJPA-2788=5D_addressing_issue_with_anonymous_parameter?= =?utf-8?q?s?= Message-ID: <160795192982.15632.6654333697253707353.asfpy@gitbox.apache.org> Date: Mon, 14 Dec 2020 13:18:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: struberg commented on pull request #42: URL: https://github.com/apache/openjpa/pull/42#issuecomment-744433991 Hi! sorry for taking so long! I opted for a slightly less impacting change. Anynomous params are now only treated as the same if they are the same instance. The whole case is imo rather underspecified in the JPA spec. But I think it's now as good as it gets. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org