openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENJPA-2773) set minIdle to > 0 in DBCPDriverDataSource
Date Thu, 07 Feb 2019 08:57:00 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-2773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762493#comment-16762493
] 

ASF subversion and git services commented on OPENJPA-2773:
----------------------------------------------------------

Commit fa6ce77004739d9601bfde43e06f9446ab601698 in openjpa's branch refs/heads/master from
Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=fa6ce77 ]

OPENJPA-2773 set dbcp defaults to align with commons dbcp

Especially the maxIdle=0 was problematic.
It effectively disables the whole pooling, which is counter productive.


> set minIdle to > 0 in DBCPDriverDataSource
> ------------------------------------------
>
>                 Key: OPENJPA-2773
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2773
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: jdbc
>    Affects Versions: 3.0.0
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>            Priority: Major
>             Fix For: 3.0.1
>
>
> Right now our {{DBCPDriverDataSource}} by default sets the {{maxIdle}} to 1. 
> This is not wrong but also not really good in terms of performance.
> It is usually much better to keep it at a much higher number. Usually somewhere around
{{maxActive}}, except when maxActive is really high.
> So I'd rather keep it at 10 or even at maxActive if this param is set.
> If the connections are not used, then they will get unlocked after some time anyway.
> But keeping the number 1 for {{maxIdle}} basically disables the pool, which is not wise.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message