Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@openjpa.apache.org
Date: Sun, 13 Apr 2014 17:06:14 +0000 (UTC)
From: "Romain Manni-Bucau (JIRA)" <jira@apache.org>
To: dev@openjpa.apache.org
Message-ID: <JIRA.12707959.1397228010888.107626.1397408774633@arcas>
In-Reply-To: <JIRA.12707959.1397228010888@arcas>
References: <JIRA.12707959.1397228010888@arcas>
Subject: [jira] [Comment Edited] (OPENJPA-2489) Delayed collection proxy
 tests failing with Java 8
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OPENJPA-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967883#comment-13967883 ] 

Romain Manni-Bucau edited comment on OPENJPA-2489 at 4/13/14 5:04 PM:
----------------------------------------------------------------------

looked a bit more and think it comes from the fact new java 8 methods are not handled (for instance spliterator()) etc, adding this block helps:

{code}
        // java 8: api we can't import so either we ignore it (acceptable IMO) for now
        // or we generate it through asm if needed
        _ignoreMethods.add(stringMethodName("spliterator", null));
        _ignoreMethods.add(stringMethodName("stream", null));
        _ignoreMethods.add(stringMethodName("parallelStream", null));
        _ignoreMethods.add("removeIf:java.util.function.Predicate");
        _ignoreMethods.add("forEach:java.util.function.Consumer");
        _ignoreMethods.add("replaceAll:java.util.function.UnaryOperator");
        _ignoreMethods.add("sort:java.util.Comparator");
{code}


was (Author: romain.manni-bucau):
looked a bit more and think it comes from the fact new java 8 methods are not handled (for instance spliterator()) etc, adding this block helps:

{code}
+        // java 8: api we can't import so either we ignore it (acceptable IMO) for now or we generate it through asm if needed
+        _ignoreMethods.add(stringMethodName("spliterator", null));
+        _ignoreMethods.add(stringMethodName("stream", null));
+        _ignoreMethods.add(stringMethodName("parallelStream", null));
+        _ignoreMethods.add("removeIf:java.util.function.Predicate");
+        _ignoreMethods.add("forEach:java.util.function.Consumer");
+        _ignoreMethods.add("replaceAll:java.util.function.UnaryOperator");
+
{code}

> Delayed collection proxy tests failing with Java 8
> --------------------------------------------------
>
>                 Key: OPENJPA-2489
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2489
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jdbc
>    Affects Versions: 2.4.0
>         Environment: Java 8
> java version "1.8.0"
> Java(TM) SE Runtime Environment (build 1.8.0-b132)
> Java HotSpot(TM) Client VM (build 25.0-b70, mixed mode)
>            Reporter: Kevin Sutter
>
> Several proxy tests are failing in the openjpa-persistence-jdbc bucket related to the delayed collection tests.  Most likely this is due to the Map interface changes introduced by Java 8.  List of failed tests:
> Failed tests:
> testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.hset.TestDelayedHashSetProxyDetachLite)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.hset.TestDelayedHashSetProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.pqueue.TestDelayedPriorityQueueProxyDetachLite)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.llist.TestDelayedLinkedListProxyDetachLite)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.llist.TestDelayedLinkedListProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.tset.TestDelayedTreeSetProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.lhset.TestDelayedLinkedHashSetProxyDetachLite)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.lhset.TestDelayedLinkedHashSetProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.vec.TestDelayedVectorProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.tset.TestDelayedTreeSetProxyDetachLite)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.alist.TestDelayedArrayListProxyDetachLite)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.alist.TestDelayedArrayListProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.pqueue.TestDelayedPriorityQueueProxy)
>   testProxyMethods(org.apache.openjpa.persistence.proxy.delayed.vec.TestDelayedVectorProxyDetachLite)
> I took a quick look at the surefire report and the error makes no sense why Java 8 would affect this outcome:
>     <failure message="Expected regular expression &lt;SELECT .* DC_EMPLOYEE .* &gt;
>  to be contained in SQL statements: 
> SELECT t0.id FROM DC_DEPARTMENT t0 WHERE t0.id = ?
> SELECT t0.awdName, t0.awdType FROM DC_DEP_AWD t0 WHERE t0.DEPARTMENT_ID = ?
> SELECT t1.id, t1.name FROM DC_DEP_PRD t0 INNER JOIN Product t1 ON t0.PRODUCTS_ID = t1.id WHERE t0.DEPARTMENT_ID = ?
> We will need to resolve this before claiming support for Java 8.


--
This message was sent by Atlassian JIRA
(v6.2#6252)