openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENJPA-2283) Upgrade to ASM 4 dependency
Date Wed, 09 Oct 2013 22:00:43 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790904#comment-13790904
] 

Mark Struberg commented on OPENJPA-2283:
----------------------------------------

This looks like a pretty heavy bug in ASM so far.

ClassWriter#getCommonSuperClass always only takes the own ClassLoader. 
I thought this has been fixed in ASM-4 but got proven wrong. 

The original code have had a hack by overwriting this method and providing an own ClassLoader
for this operation. This is not really possible anymore with the dynamic approach as there
is no fixed class we can extend. This would only be possible with ASM which is kind of a chicken-egg
problem now.

I suggest to code against xbean-asm4-shaded instead of ASM directly. This has the benefit
that we at least know which exact version we have - without trashing other project or getting
trashed by customer dependencies.

> Upgrade to ASM 4 dependency
> ---------------------------
>
>                 Key: OPENJPA-2283
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2283
>             Project: OpenJPA
>          Issue Type: New Feature
>          Components: Enhance
>    Affects Versions: 2.3.0
>            Reporter: Kevin Sutter
>             Fix For: 2.3.0
>
>         Attachments: openjpa-2283.problem.patch
>
>
> OpenJPA currently has a dependency on ASM 3.2 for some post-enhancement processing to
fix up the stack map tables (Java 7 requirement).  The latest release of ASM is 4.1, which
just came out last week.  The immediate need is to move up to ASM 4.0.  We can entertain 4.1
at a later date.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message