openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sutter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENJPA-2283) Upgrade to ASM 4 dependency
Date Fri, 04 Oct 2013 18:38:42 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786475#comment-13786475
] 

Kevin Sutter commented on OPENJPA-2283:
---------------------------------------

Mark, okay, I give...  :-)  I just talked with Rick and he convinced me this was okay.  I
have always struggled with this change since I was wondering why would we (OpenJPA) be checking
for these alternate packages, when we don't have a direct dependency on them.  But, this is
for application server environments like you said.  Environments where there might be multiple
versions of ASM (both app server and application), and OpenJPA needs to use the "right one".
 In OpenJPA's premier app server (WebSphere), we can determine which ASM to use based on the
classloader "magic".  But, that ability is not always available in every environment.  So,
I'm good with this ordering change.

But, since we're re-looking at this change due to the ASM 4 upgrade, should the xbean-asm4
be first in the list?  I know that differs from my earlier comment, but now that I understand
why you want the xbean shaded jars first, it would seem logical to have xbean-asm4 first.

> Upgrade to ASM 4 dependency
> ---------------------------
>
>                 Key: OPENJPA-2283
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2283
>             Project: OpenJPA
>          Issue Type: New Feature
>          Components: Enhance
>    Affects Versions: 2.3.0
>            Reporter: Kevin Sutter
>             Fix For: 2.3.0
>
>         Attachments: openjpa-2283.problem.patch
>
>
> OpenJPA currently has a dependency on ASM 3.2 for some post-enhancement processing to
fix up the stack map tables (Java 7 requirement).  The latest release of ASM is 4.1, which
just came out last week.  The immediate need is to move up to ASM 4.0.  We can entertain 4.1
at a later date.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message