openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Curtis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENJPA-2410) Build time detection of System.out/err.print(ln) in source files
Date Sat, 03 Aug 2013 17:01:51 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728592#comment-13728592
] 

Rick Curtis commented on OPENJPA-2410:
--------------------------------------

I'll note that when running on maven 3.x or newer you'll get the following failure :

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.673s
[INFO] Finished at: Sat Aug 03 12:00:11 CDT 2013
[INFO] Final Memory: 30M/60M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.4:checkstyle
(default) on project openjpa-lib: Execution default of goal org.apache.maven.plugins:mav
en-checkstyle-plugin:2.4:checkstyle failed. NullPointerException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following
articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :openjpa-lib
                
> Build time detection of System.out/err.print(ln) in source files
> ----------------------------------------------------------------
>
>                 Key: OPENJPA-2410
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2410
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: build / infrastructure
>    Affects Versions: 2.3.0
>            Reporter: Di Wu Lau
>            Assignee: Rick Curtis
>            Priority: Minor
>             Fix For: 1.2.4, 2.3.0, 2.2.3
>
>         Attachments: OPENJPA-2410.patch, OPENJPA-2410r1.patch, OPENJPA-2410r2.patch
>
>
> Source files may have inadvertent System.out/err.print statements left in source files
on commit. Ideally we don't want any of these changes being checked in and a large majority
of the time logging facilities should be utilized. That being said, there are a number of
cases where we don't have access to a logger and must use System.out/err.
> This JIRA will be used to update our checkstyle to scan for unwanted print statements,
and fail the build when/if they are encountered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message