openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Curtis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENJPA-2410) Build time detection of System.out/err.print(ln) in source files
Date Thu, 18 Jul 2013 21:38:48 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712898#comment-13712898
] 

Rick Curtis commented on OPENJPA-2410:
--------------------------------------

I'll note that the code that I committed was somewhat different than your last patch. I decided
to go back to allowing a comment to dis/enable checking to allow for exclusions. 

Going forward, if you want to have code that has a System.out/err in it you'll need to use
the comment '// START - ALLOW PRINT STATEMENTS' to tell the checkstyle plugin to stop checking...
and then us the comment '// STOP - ALLOW PRINT STATEMENTS' to re-enable checking. I'll cross
post this to the users / dev list and try to get some info on the wiki also.

ie:

                    // START - ALLOW PRINT STATEMENTS
                    System.err.println("Not handled " + fmd.getName() + " of type " + fmd.getDeclaredType());
                    // STOP - ALLOW PRINT STATEMENTS
                
> Build time detection of System.out/err.print(ln) in source files
> ----------------------------------------------------------------
>
>                 Key: OPENJPA-2410
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2410
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: build / infrastructure
>    Affects Versions: 2.3.0
>            Reporter: Di Wu Lau
>            Assignee: Rick Curtis
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: OPENJPA-2410.patch
>
>
> Source files may have inadvertent System.out/err.print statements left in source files
on commit. Ideally we don't want any of these changes being checked in and a large majority
of the time logging facilities should be utilized. That being said, there are a number of
cases where we don't have access to a logger and must use System.out/err.
> This JIRA will be used to update our checkstyle to scan for unwanted print statements,
and fail the build when/if they are encountered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message