Return-Path: 
 <dev-return-22010-apmail-openjpa-dev-archive=openjpa.apache.org@openjpa.apache.org>
X-Original-To: apmail-openjpa-dev-archive@www.apache.org
Delivered-To: apmail-openjpa-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C98F0D088
	for <apmail-openjpa-dev-archive@www.apache.org>;
 Wed, 15 May 2013 12:19:17 +0000 (UTC)
Received: (qmail 71389 invoked by uid 500); 15 May 2013 12:19:17 -0000
Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org
Received: (qmail 71267 invoked by uid 500); 15 May 2013 12:19:17 -0000
Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@openjpa.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@openjpa.apache.org>
List-Post: <mailto:dev@openjpa.apache.org>
List-Id: <dev.openjpa.apache.org>
Reply-To: dev@openjpa.apache.org
Delivered-To: mailing list dev@openjpa.apache.org
Received: (qmail 70859 invoked by uid 99); 15 May 2013 12:19:16 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 May 2013 12:19:16 +0000
Date: Wed, 15 May 2013 12:19:16 +0000 (UTC)
From: "Vermeulen (JIRA)" <jira@apache.org>
To: dev@openjpa.apache.org
Message-ID: <JIRA.12626144.1357347014540.323280.1368620356392@arcas>
In-Reply-To: <JIRA.12626144.1357347014540@arcas>
References: <JIRA.12626144.1357347014540@arcas>
Subject: [jira] [Commented] (OPENJPA-2318) Left outer join is not generated
 when specifien using Criteria API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/OPENJPA-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658292#comment-13658292 ] 

Vermeulen commented on OPENJPA-2318:
------------------------------------

I created an (almost) official OpenJPA test case that reproduces the issue.
I took the CriteriaTest TestJPQLSubquery.testSubqueries6 as a starting point to create the test. It reuses the existing structure

Customer 1..* accounts 1..1 owner

    public void testLeftJoinAfterInnerJoin() {
        String jpql = "SELECT c FROM Customer c INNER JOIN c.accounts a LEFT JOIN a.owner o";
        String expectedSQL = "SELECT t0.id, t0.accountNum, t4.id, t4.city, t4.country, t4.county, t4.state, " +
        		"t4.street, t5.userid, t5.DTYPE, t5.age, t5.compName, t5.creditRating, t5.name, t4.zipCode, " +
        		"t0.balanceOwed, t0.creditRating, t0.filledOrderCount, t0.firstName, t0.lastName, t0.name, t0.status " +
        		"FROM CR_CUST t0 " +
        		"INNER JOIN CR_CUST_CR_ACCT t1 ON t0.id = t1.CUSTOMER_ID " +
        		"LEFT OUTER JOIN CR_ADDR t4 ON t0.ADDRESS_ID = t4.id " +
        		"INNER JOIN CR_ACCT t2 ON t1.ACCOUNTS_ID = t2.id " +
        		"LEFT OUTER JOIN CompUser t5 ON t4.id = t5.ADD_ID " +
        		"LEFT OUTER JOIN CR_PSN t3 ON t2.OWNER_ID = t3.id";

        executeAndCompareSQL(jpql, expectedSQL);
        
        CriteriaQuery<Customer> q = cb.createQuery(Customer.class);
        Root<Customer> c = q.from(Customer.class);
        Join<Customer,Account> a = c.join(Customer_.accounts);
        Join<Account, Person> o = a.join(Account_.owner, JoinType.LEFT);
        q.select(c);
        
        assertEquivalence(q, jpql);
    }

Simply copy/paste into TestJPQLSubquery and run.
You will get a nice assertion error that compares the SQL for the JPQL query with the SQL for the Criteria query and you can see that only the last part of the query differs. JPQL has "LEFT OUTER JOIN" while Criteria has "INNER JOIN".

Can an OpenJPA committer look into this? I think I have now done the necessary work I can do to pinpoint the issue.
                
> Left outer join is not generated when specifien using Criteria API
> ------------------------------------------------------------------
>
>                 Key: OPENJPA-2318
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2318
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: criteria
>    Affects Versions: 2.1.1
>         Environment: Windows/Oracle
>            Reporter: Lev
>
> Entities
> @Entity
> @Inheritance(strategy = InheritanceType.TABLE_PER_CLASS)
> public class DiscoveryObjectImpl {
> 	@Id
> 	private String id;
> 	public String getId() {
> 		return id;
> 	}
> 	public void setId(String id) {
> 		this.id = id;
> 	}
> 	@ManyToOne(cascade = CascadeType.ALL)
> 	private DiscoveryObjectImpl parent;
> 	
> 	public DiscoveryObjectImpl getParent() {		
> 		return parent;
> 	}
> 	public void setParent(DiscoveryObjectImpl parent) {
> 		this.parent = parent;  
> 	}
> }
> @Entity
> public class ColumnFormatImpl extends DiscoveryObjectImpl {
> 	@Basic
> 	String formatName; 
> }
> @Entity
> public class ColumnImpl extends DiscoveryObjectImpl {
> @OneToMany(mappedBy="parent")
> private List<ColumnFormatImpl> formats = new ArrayList<ColumnFormatImpl>();
> }
> @Entity
> public class VirtualTableImpl extends DiscoveryObjectImpl {
> @OneToMany(mappedBy="parent")
> 	private List<ColumnImpl> columns = new ArrayList<ColumnImpl>();
> }
> persistence.xml
> <persistence xmlns="http://java.sun.com/xml/ns/persistence"
>     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>     xsi:schemaLocation="http://java.sun.com/xml/ns/persistence http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd"
>     version="1.0">
>  <persistence-unit name="Test" transaction-type="RESOURCE_LOCAL">
>  	<provider>org.apache.openjpa.persistence.PersistenceProviderImpl</provider>
>  	<class>com.ibm.infosphere.test.model.interfaces.impl.DiscoveryObjectImpl</class>
>  	<class>com.ibm.infosphere.test.model.interfaces.impl.VirtualTableImpl</class>
>  	<class>com.ibm.infosphere.test.model.interfaces.impl.ColumnImpl</class>
>  	<class>com.ibm.infosphere.test.model.interfaces.impl.ColumnFormatImpl</class> 	
>  	<exclude-unlisted-classes>true</exclude-unlisted-classes> 			
> 	<properties>
> 			<property name="openjpa.Log" value="DefaultLevel=ERROR, Runtime=ERROR, Tool=ERROR, SQL=TRACE, MetaData=ERROR"/>
> 			<property name="openjpa.DynamicEnhancementAgent"  value="false"/>
>             <property name="openjpa.RuntimeUnenhancedClasses" value="supported"/>
>             <property name="openjpa.jdbc.SynchronizeMappings" value="buildSchema(ForeignKeys=true)"/>
>             <property name="openjpa.InitializeEagerly" value="true"/>
>             <property name="openjpa.jdbc.DBDictionary" value="oracle"/>
>             <property name="openjpa.jdbc.DBDictionary" value="MaxTableNameLength=61"/>
>             <property name="openjpa.jdbc.DBDictionary" value="useWildCardForCount=true"/>
>             <property name="openjpa.jdbc.DBDictionary" value="JoinSyntax=sql92"/>
>  			<property name="openjpa.ConnectionURL" value="jdbc:oracle:thin:@localhost:1521:orcl"/>
> 			 
>     		<property name="openjpa.ConnectionDriverName" value="oracle.jdbc.driver.OracleDriver"/> 
>       		<property name="openjpa.ConnectionUserName" value="lev"/>
>       		<property name="openjpa.ConnectionPassword" value="lev"/>
>             <property name="openjpa.ConnectionFactoryProperties"    value="PrettyPrint=true, PrettyPrintLineLength=80, PrintParameters=true"/>
>             <property name="openjpa.DataCache"                value="true"/>        
>             <property name="openjpa.RemoteCommitProvider"     value="sjvm"/>            
>             <property name="openjpa.jdbc.QuerySQLCache"       value="true(EnableStatistics=true)"/>            
> 		</properties>
> </persistence-unit>
> </persistence>
> Test code:
> public void test() {
>         CriteriaQuery<ColumnImpl> cri = cb.createQuery(ColumnImpl.class);
>         Root<VirtualTableImpl> tbl = cri.from(VirtualTableImpl.class);
>         Join<VirtualTableImpl, ColumnImpl> col = tbl.join("columns");
>         Join<ColumnImpl, ColumnFormatImpl> format = col.join("formats", JoinType.LEFT);
>         cri.where(cb.equal(format.get("formatName"), "ABC"));
>         cri.select(col);
>         em.createQuery(cri).getResultList();
> }
> Generated SQL:
> SELECT t1.id, t1.PARENT_ID 
>     FROM VirtualTableImpl t0 INNER JOIN ColumnImpl t1 ON t0.id = t1.PARENT_ID INNER 
>         JOIN ColumnFormatImpl t2 ON t1.id = t2.PARENT_ID 
>     WHERE (t2.formatName = ? AND 1 = 1) 
> As you can see the secong JOIN is INNER instead of LEFT OUTER
>         

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira