openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENJPA-1912) enhancer generates invalid code if fetch-groups is activated
Date Fri, 17 May 2013 21:25:16 GMT

    [ https://issues.apache.org/jira/browse/OPENJPA-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661057#comment-13661057
] 

ASF subversion and git services commented on OPENJPA-1912:
----------------------------------------------------------

Commit 1483996 from hthomann
[ https://svn.apache.org/r1483996 ]

OPENJPA-1912: Generate externalizable methods correctly for super and subclasses - back ported
to 2.1.x Mark Struberg's trunk changes.
                
> enhancer generates invalid code if fetch-groups is activated
> ------------------------------------------------------------
>
>                 Key: OPENJPA-1912
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-1912
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: Enhance
>    Affects Versions: 2.0.0, 2.0.1, 2.1.0
>            Reporter: Mark Struberg
>            Assignee: Michael Dick
>            Priority: Critical
>             Fix For: 2.2.0
>
>         Attachments: OPENJPA-1912-enhancer.patch, OPENJPA-1912-fix-wo_cleanup-2.patch,
OPENJPA-1912-fix-wo_cleanup.patch, OPENJPA-1912-mdd.diff.txt, OPENJPA-1912-test.patch
>
>
> If openjpa.DetachState =fetch-groups is used, the enhancer will add a 'implements Externalizable'
+ writeExternal + readExternal.
> The problem is, that writeExternal and readExternal will also try to externalize the
private members of any given superclass. Thus we get a runtime Exception that we are not allowed
to access those fields.
> Example:
> @Entity
> public abstract class AbstractGroup {
>    ...
>     @Temporal(TemporalType.TIMESTAMP)
>     @TrackChanges
>     private Date applicationBegin;
>  ...
> }
> and 
> @Entity
> public class Group extends AbstractGroup {
> ...
> }
> will result in the following code (decompiled with jad):
>     public void writeExternal(ObjectOutput objectoutput)
>         throws IOException
>     {
>         pcWriteUnmanaged(objectoutput);
>         if(pcStateManager != null)
>         {
>             if(pcStateManager.writeDetached(objectoutput))
>                 return;
>         } else
>         {
>             objectoutput.writeObject(pcGetDetachedState());
>             objectoutput.writeObject(null);
>         }
>         objectoutput.writeObject(applicationBegin);
>         objectoutput.writeObject(applicationEnd);
>         objectoutput.writeObject(applicationLocked);
>         objectoutput.writeObject(approvalRequired);
>  ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message