Return-Path: X-Original-To: apmail-openjpa-dev-archive@www.apache.org Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC97DF2F4 for ; Wed, 27 Mar 2013 14:43:16 +0000 (UTC) Received: (qmail 95695 invoked by uid 500); 27 Mar 2013 14:43:16 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 95623 invoked by uid 500); 27 Mar 2013 14:43:16 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 95520 invoked by uid 99); 27 Mar 2013 14:43:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2013 14:43:16 +0000 Date: Wed, 27 Mar 2013 14:43:16 +0000 (UTC) From: "Rick Curtis (JIRA)" To: dev@openjpa.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (OPENJPA-1741) Unecessary class load attempts when parsing JPQL MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OPENJPA-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick Curtis resolved OPENJPA-1741. ---------------------------------- Resolution: Won't Fix > Unecessary class load attempts when parsing JPQL > ------------------------------------------------ > > Key: OPENJPA-1741 > URL: https://issues.apache.org/jira/browse/OPENJPA-1741 > Project: OpenJPA > Issue Type: Bug > Components: query > Affects Versions: 1.2.2, 2.0.0 > Reporter: David Minor > Assignee: Rick Curtis > Attachments: cache-class-load-attempts.patch, only-load-uppercase-java-lang.patch, skip-known-variables.patch > > > When parsing JPQL, JPQLExpressionBuilder.getPathOrConstant() tries to determine if a token is a java class or enum by doing a class load (via QueryImpl.classForName()). The same token will be tried as often as it appears in the query. It might be better to > 1) cache the results > 2) avoid the lookup if the token is a known variable name -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira