Return-Path: X-Original-To: apmail-openjpa-dev-archive@www.apache.org Delivered-To: apmail-openjpa-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 592C3E55F for ; Wed, 13 Feb 2013 21:04:13 +0000 (UTC) Received: (qmail 1108 invoked by uid 500); 13 Feb 2013 21:04:13 -0000 Delivered-To: apmail-openjpa-dev-archive@openjpa.apache.org Received: (qmail 963 invoked by uid 500); 13 Feb 2013 21:04:13 -0000 Mailing-List: contact dev-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list dev@openjpa.apache.org Received: (qmail 954 invoked by uid 99); 13 Feb 2013 21:04:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Feb 2013 21:04:13 +0000 Date: Wed, 13 Feb 2013 21:04:13 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@openjpa.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (OPENJPA-1530) MySQL storage engine support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/OPENJPA-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577935#comment-13577935 ] ASF subversion and git services commented on OPENJPA-1530: ---------------------------------------------------------- Commit 1445923 from rpalache [ https://svn.apache.org/r1445923 ] OPENJPA-1530 change TYPE to ENGINE in DDL for MySQL > MySQL storage engine support > ---------------------------- > > Key: OPENJPA-1530 > URL: https://issues.apache.org/jira/browse/OPENJPA-1530 > Project: OpenJPA > Issue Type: Improvement > Components: jdbc > Reporter: Craig L Russell > Assignee: Craig L Russell > Priority: Minor > Fix For: 1.3.0, 2.0.0-beta3 > > Attachments: openjpa-1530.patch > > > The MySQLDictionary currently supports only TYPE innodb. There is a skeleton for support of this element but there is no way to change it from the default. > Also, according to the MySQL documentation http://dev.mysql.com/doc/refman/5.1/en/create-table.html TYPE is deprecated. The recommended (and supported) keyword is ENGINE. > "Since MySQL 5.1.8, it produces a warning. It will be removed in a future MySQL release. You should not use TYPE in any new applications, and you should immediately begin conversion of existing applications to use ENGINE instead." > I propose to change TYPE to ENGINE, and to provide a way for the user to specify which engine to use. > I need some feedback on this: A property, mysql.engine, with a default of innodb (for compatibility) can be specified by the user in order to create tables using any of the supported engines. Can the property be put onto the command line? Can the property be added to persistence.xml? Can the property be added to the maven profile properties? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira